Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code Coverage documentation #7027

Closed
wants to merge 2 commits into from

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Sep 1, 2023

No issue

Describe your changes:

Provides a second pass at our codecov documentation. My original intent was to fix this documentation after we implented the bash uploader pattern... but that hasn't happened yet.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #7027 (3fc1141) into master (c27ad46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7027   +/-   ##
=======================================
  Coverage   48.77%   48.77%           
=======================================
  Files         643      643           
  Lines       25730    25730           
  Branches     2512     2512           
=======================================
  Hits        12549    12549           
- Misses      12685    12687    +2     
+ Partials      496      494    -2     
Flag Coverage Δ *Carryforward flag
e2e-full 42.02% <ø> (ø) Carriedforward from a9b0ec5
e2e-stable 57.14% <ø> (-0.03%) ⬇️
unit 39.47% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27ad46...3fc1141. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Sep 1, 2023
@deploysentinel
Copy link

deploysentinel bot commented Sep 1, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/01/2023 01:25:30am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 3fc1141

Started: 09/01/2023 01:18:54am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.44% (2) 2 / 82 runs
failed over last 7 days
36.59% (30) 30 / 82 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 80 runs
failed over last 7 days
57.50% (46) 46 / 80 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 80 runs
failed over last 7 days
48.75% (39) 39 / 80 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 113 runs
failed over last 7 days
46.90% (53) 53 / 113 runs
flaked over last 7 days

View Detailed Build Results


ozyx
ozyx previously requested changes Sep 1, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I just have a couple nitpicks

TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
The e2e line coverage is a bit more complex than the karma implementation. M

It generally follows the following flow:
1. Each e2e suite will start the webpack.coverage.js config with the `npm run start:coverage` command which configures webpack with the `babel-plugin-istanbul` babel-loader to generate code coverage during e2e test execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is valid markdown, but let's number these 1, 2, 3, 4.. etc. Just so that if someone is not reading this in a markdown viewer they don't get confused.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fight you over this... In the markdown linter pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm up for this fight hahahah

@@ -37,14 +37,42 @@ Documentation located [here](./e2e/README.md)

## Code Coverage

* 100% statement coverage is achievable and desirable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@unlikelyzero
Copy link
Collaborator Author

I made the corrections. Let's wait for Even to run through this to make sure it makes sense

@msf-caesar

This comment was marked as spam.

@unlikelyzero
Copy link
Collaborator Author

Closing in favor of #6988

@unlikelyzero unlikelyzero deleted the code-coverage-documentation branch September 4, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants