-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code Coverage documentation #7027
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7027 +/- ##
=======================================
Coverage 48.77% 48.77%
=======================================
Files 643 643
Lines 25730 25730
Branches 2512 2512
=======================================
Hits 12549 12549
- Misses 12685 12687 +2
+ Partials 496 494 -2
*This pull request uses carry forward flags. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/01/2023 01:25:30am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.44% (2)2 / 82 runsfailed over last 7 days |
36.59% (30)30 / 82 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 80 runsfailed over last 7 days |
57.50% (46)46 / 80 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 80 runsfailed over last 7 days |
48.75% (39)39 / 80 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 113 runsfailed over last 7 days |
46.90% (53)53 / 113 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I just have a couple nitpicks
The e2e line coverage is a bit more complex than the karma implementation. M | ||
|
||
It generally follows the following flow: | ||
1. Each e2e suite will start the webpack.coverage.js config with the `npm run start:coverage` command which configures webpack with the `babel-plugin-istanbul` babel-loader to generate code coverage during e2e test execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is valid markdown, but let's number these 1, 2, 3, 4.. etc. Just so that if someone is not reading this in a markdown viewer they don't get confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fight you over this... In the markdown linter pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm up for this fight hahahah
@@ -37,14 +37,42 @@ Documentation located [here](./e2e/README.md) | |||
|
|||
## Code Coverage | |||
|
|||
* 100% statement coverage is achievable and desirable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
I made the corrections. Let's wait for Even to run through this to make sure it makes sense |
This comment was marked as spam.
This comment was marked as spam.
Closing in favor of #6988 |
No issue
Describe your changes:
Provides a second pass at our codecov documentation. My original intent was to fix this documentation after we implented the bash uploader pattern... but that hasn't happened yet.
All Submissions:
Author Checklist
Reviewer Checklist