Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6990): Fix and re-enable disabled unit test suites #7049

Merged
merged 1 commit into from Sep 12, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Sep 12, 2023

Issue #7016
Issue #7019

Note: Merge #7051 first

@deploysentinel
Copy link

deploysentinel bot commented Sep 12, 2023

Current Playwright Test Results Summary

✅ 138 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/12/2023 05:53:21pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 85ba502

Started: 09/12/2023 05:46:15pm UTC

⚠️ Flakes

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
2.78% (1) 1 / 36 run
failed over last 7 days
2.78% (1) 1 / 36 run
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
5.13% (2) 2 / 39 runs
failed over last 7 days
30.77% (12) 12 / 39 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 1Initial Attempt
0% (0) 0 / 37 runs
failed over last 7 days
5.41% (2) 2 / 37 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 69 runs
failed over last 7 days
47.83% (33) 33 / 69 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/3.0.2@cbe4967). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/3.0.2    #7049   +/-   ##
================================================
  Coverage                 ?   55.64%           
================================================
  Files                    ?      644           
  Lines                    ?    25719           
  Branches                 ?     2512           
================================================
  Hits                     ?    14312           
  Misses                   ?    10708           
  Partials                 ?      699           
Flag Coverage Δ *Carryforward flag
e2e-full 42.07% <0.00%> (?) Carriedforward from f705bf9
e2e-stable 56.42% <0.00%> (?)
unit 49.36% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe4967...85ba502. Read the comment docs.

@unlikelyzero
Copy link
Collaborator

@ozyx

page.getByRole(...).or is not a function


@ozyx
Copy link
Member Author

ozyx commented Sep 12, 2023

@ozyx

page.getByRole(...).or is not a function

but it is tho...

ah, i see. we're on 1.32.3 and need to be on >=1.33

* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
@unlikelyzero unlikelyzero merged commit b923af8 into release/3.0.2 Sep 12, 2023
10 of 12 checks passed
@unlikelyzero unlikelyzero deleted the cherry-pick-timer-fix-2 branch September 12, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants