Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filters] Fix view based filters when string input is enabled #7050

Merged
merged 11 commits into from Oct 24, 2023

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Sep 12, 2023

Closes #7006

Describe your changes:

Modified the logic for filters that do not have the "possibleValues" key in their metadata which allows string input.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Sep 12, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 10:16:05pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 751053d

Started: 10/24/2023 10:11:03pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 2Retry 1Initial Attempt
0% (0) 0 / 36 runs
failed over last 7 days
5.56% (2) 2 / 36 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 10:16:05pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 751053d

Started: 10/24/2023 10:09:08pm UTC

⚠️ Flakes

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0.93% (1) 1 / 107 run
failed over last 7 days
50.47% (54) 54 / 107 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
7.50% (6) 6 / 80 runs
failed over last 7 days
48.75% (39) 39 / 80 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
2.47% (2) 2 / 81 runs
failed over last 7 days
69.14% (56) 56 / 81 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #7050 (fbf427d) into master (13311b9) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head fbf427d differs from pull request most recent head 751053d. Consider uploading reports for the commit 751053d to get more accurate results

@@            Coverage Diff             @@
##           master    #7050      +/-   ##
==========================================
- Coverage   55.77%   55.70%   -0.08%     
==========================================
  Files         651      651              
  Lines       26187    26189       +2     
  Branches     2535     2536       +1     
==========================================
- Hits        14607    14589      -18     
- Misses      10881    10894      +13     
- Partials      699      706       +7     
Flag Coverage Δ *Carryforward flag
e2e-full 41.75% <ø> (ø) Carriedforward from 13311b9
e2e-stable 57.32% <ø> (+0.13%) ⬆️
unit 49.35% <0.00%> (-0.09%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...telemetryTable/components/TableFooterIndicator.vue 25.45% <ø> (-0.97%) ⬇️
src/plugins/filters/components/FilterField.vue 0.00% <0.00%> (ø)
src/plugins/filters/components/FiltersView.vue 2.85% <0.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f92cd4...751053d. Read the comment docs.

Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question for you plus it looks like one of the e2e is failing?

src/plugins/filters/components/FilterField.vue Outdated Show resolved Hide resolved
src/plugins/telemetryTable/TelemetryTable.js Outdated Show resolved Hide resolved
@jvigliotta jvigliotta requested a review from ozyx October 24, 2023 21:38
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@ozyx ozyx added this to the Target:3.2.0 milestone Oct 24, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@ozyx ozyx merged commit 7bf9832 into master Oct 24, 2023
19 of 20 checks passed
@ozyx ozyx deleted the filter-string-fix branch October 24, 2023 22:33
@ozyx ozyx removed this from the Target:3.2.0 milestone Oct 24, 2023
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filters] Filters without the "possibleValues" and string values are causing errors
3 participants