Allow Data Visualization in inspector based on current selection #7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidadil
reviewed
Sep 12, 2023
khalidadil
reviewed
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #7052 +/- ##
==========================================
- Coverage 55.50% 55.46% -0.05%
==========================================
Files 643 650 +7
Lines 25787 25922 +135
Branches 2517 2532 +15
==========================================
+ Hits 14314 14378 +64
- Misses 10782 10842 +60
- Partials 691 702 +11
*This pull request uses carry forward flags. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/15/2023 02:52:14am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: b741236 Started: 09/15/2023 02:49:14am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
18.92% (7)7 / 37 runsfailed over last 7 days |
24.32% (9)9 / 37 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 138 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 09/15/2023 02:52:15am UTC)
⚠️ Flakes
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1 • Initial Attempt |
0% (0)0 / 63 runsfailed over last 7 days |
6.35% (4)4 / 63 runsflaked over last 7 days |
|
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1 • Initial Attempt |
0% (0)0 / 63 runsfailed over last 7 days |
6.35% (4)4 / 63 runsflaked over last 7 days |
|
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 1 • Initial Attempt |
0% (0)0 / 61 runsfailed over last 7 days |
6.56% (4)4 / 61 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
3.23% (2)2 / 62 runsfailed over last 7 days |
43.55% (27)27 / 62 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
3.33% (2)2 / 60 runsfailed over last 7 days |
35% (21)21 / 60 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.09% (1)1 / 92 runfailed over last 7 days |
51.09% (47)47 / 92 runsflaked over last 7 days |
|
Note: flaky tree expanding test in percy |
khalidadil
approved these changes
Sep 15, 2023
|
Looks great! Nice one. Very clean and reusable, I like it. |
|
Filed a followup for some docs and tests - #7060 |
akhenry
pushed a commit
that referenced
this pull request
Sep 15, 2023
* visualize data in inspector per selection --------- Co-authored-by: Khalid Adil <khalidadil29@gmail.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
khalidadil
added a commit
that referenced
this pull request
Sep 18, 2023
…rrent selection (#7062) Allow Data Visualization in inspector based on current selection (#7052) * visualize data in inspector per selection --------- Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com> Co-authored-by: Khalid Adil <khalidadil29@gmail.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7041
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist