Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump sass from 1.63.4 to 1.67.0 #7058

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 14, 2023

Bumps sass from 1.63.4 to 1.67.0.

Release notes

Sourced from sass's releases.

Dart Sass 1.67.0

To install Sass 1.67.0, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

  • All functions defined in CSS Values and Units 4 are now once again parsed as calculation objects: round(), mod(), rem(), sin(), cos(), tan(), asin(), acos(), atan(), atan2(), pow(), sqrt(), hypot(), log(), exp(), abs(), and sign().

    Unlike in 1.65.0, function calls are not locked into being parsed as calculations or plain Sass functions at parse-time. This means that user-defined functions will take precedence over CSS calculations of the same name. Although the function names calc() and clamp() are still forbidden, users may continue to freely define functions whose names overlap with other CSS calculations (including abs(), min(), max(), and round() whose names overlap with global Sass functions).

  • As a consequence of the change in calculation parsing described above, calculation functions containing interpolation are now parsed more strictly than before. However, all interpolations that would have produced valid CSS will continue to work, so this is not considered a breaking change.

  • Interpolations in calculation functions that aren't used in a position that could also have a normal calculation value are now deprecated. For example, calc(1px #{"+ 2px"}) is deprecated, but calc(1px + #{"2px"}) is still allowed. This deprecation is named calc-interp. See the Sass website for more information.

  • Potentially breaking bug fix: The importer used to load a given file is no longer used to load absolute URLs that appear in that file. This was unintented behavior that contradicted the Sass specification. Absolute URLs will now correctly be loaded only from the global importer list. This applies to the modern JS API, the Dart API, and the embedded protocol.

Embedded Sass

  • Substantially improve the embedded compiler's performance when compiling many files or files that require many importer or function call round-trips with the embedded host.

See the full changelog for changes in earlier releases.

Dart Sass 1.66.1

To install Sass 1.66.1, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

JS API

  • Fix a bug where Sass compilation could crash in strict mode if passed a callback that threw a string, boolean, number, symbol, or bignum.

See the full changelog for changes in earlier releases.

Dart Sass 1.66.0

To install Sass 1.66.0, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

  • Breaking change: Drop support for the additional CSS calculations defined in CSS Values and Units 4. Custom Sass functions whose names overlapped with these new CSS functions were being parsed as CSS calculations instead, causing an unintentional breaking change outside our normal [compatibility policy] for CSS compatibility changes.

... (truncated)

Changelog

Sourced from sass's changelog.

1.67.0

  • All functions defined in CSS Values and Units 4 are now once again parsed as calculation objects: round(), mod(), rem(), sin(), cos(), tan(), asin(), acos(), atan(), atan2(), pow(), sqrt(), hypot(), log(), exp(), abs(), and sign().

    Unlike in 1.65.0, function calls are not locked into being parsed as calculations or plain Sass functions at parse-time. This means that user-defined functions will take precedence over CSS calculations of the same name. Although the function names calc() and clamp() are still forbidden, users may continue to freely define functions whose names overlap with other CSS calculations (including abs(), min(), max(), and round() whose names overlap with global Sass functions).

  • As a consequence of the change in calculation parsing described above, calculation functions containing interpolation are now parsed more strictly than before. However, all interpolations that would have produced valid CSS will continue to work, so this is not considered a breaking change.

  • Interpolations in calculation functions that aren't used in a position that could also have a normal calculation value are now deprecated. For example, calc(1px #{"+ 2px"}) is deprecated, but calc(1px + #{"2px"}) is still allowed. This deprecation is named calc-interp. See the Sass website for more information.

  • Potentially breaking bug fix: The importer used to load a given file is no longer used to load absolute URLs that appear in that file. This was unintented behavior that contradicted the Sass specification. Absolute URLs will now correctly be loaded only from the global importer list. This applies to the modern JS API, the Dart API, and the embedded protocol.

Embedded Sass

  • Substantially improve the embedded compiler's performance when compiling many files or files that require many importer or function call round-trips with the embedded host.

1.66.1

JS API

  • Fix a bug where Sass compilation could crash in strict mode if passed a callback that threw a string, boolean, number, symbol, or bignum.

1.66.0

  • Breaking change: Drop support for the additional CSS calculations defined

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file pr:daveit Disables PR Cop pr:e2e Automatically triggers e2e tests to run pr:platform Runs tests against all supported platforms type:maintenance tests, chores, or project maintenance labels Sep 14, 2023
@deploysentinel
Copy link

deploysentinel bot commented Sep 14, 2023

Current Playwright Test Results Summary

✅ 93 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/20/2023 05:49:28pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c2fd470

Started: 09/20/2023 05:45:03pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook Can be locked if at least one page has one entry @addinit
Retry 1Initial Attempt
0% (0) 0 / 108 runs
failed over last 7 days
0.93% (1) 1 / 108 run
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.89% (2) 2 / 106 runs
failed over last 7 days
35.85% (38) 38 / 106 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
0% (0) 0 / 49 runs
failed over last 7 days
81.63% (40) 40 / 49 runs
flaked over last 7 days

View Detailed Build Results


@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-1.67.0 branch from 5e5c004 to c3a3785 Compare September 18, 2023 18:25
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #7058 (c2fd470) into master (b8949db) will decrease coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7058      +/-   ##
==========================================
- Coverage   55.30%   54.36%   -0.95%     
==========================================
  Files         649      649              
  Lines       26041    26041              
  Branches     2547     2547              
==========================================
- Hits        14403    14158     -245     
- Misses      10945    11190     +245     
  Partials      693      693              
Flag Coverage Δ *Carryforward flag
e2e-full 41.98% <ø> (ø) Carriedforward from 61e7050
e2e-stable 54.15% <ø> (-3.26%) ⬇️
unit 48.68% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8949db...c2fd470. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-1.67.0 branch from c3a3785 to 406fe31 Compare September 18, 2023 18:47
Bumps [sass](https://github.com/sass/dart-sass) from 1.63.4 to 1.67.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.63.4...1.67.0)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-1.67.0 branch from 406fe31 to c2fd470 Compare September 20, 2023 17:37
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 25, 2023

Superseded by #7086.

@dependabot dependabot bot closed this Sep 25, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/sass-1.67.0 branch September 25, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pr:daveit Disables PR Cop pr:e2e Automatically triggers e2e tests to run pr:platform Runs tests against all supported platforms type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants