Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to delete annotations #7069

Merged
merged 14 commits into from Sep 25, 2023

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Sep 18, 2023

Closes #7056

Describe your changes:

Add script to delete annotations, e.g., from src/plugins/persistence/couch:

npm run deleteAnnotations:openmct:PIXEL_SPATIAL

will delete all image tags.

npm run deleteAnnotations:openmct 

will delete all tags.

npm run deleteAnnotations:openmct -- --help

will print help options.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Sep 18, 2023 that may be closed by this pull request
@scottbell scottbell changed the title 7056 couchdb add couchdb scripts to repo Add script to delete annotations Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #7069 (8a62003) into master (ff2c8b3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7069      +/-   ##
==========================================
- Coverage   55.51%   55.50%   -0.02%     
==========================================
  Files         649      649              
  Lines       26054    26054              
  Branches     2547     2547              
==========================================
- Hits        14465    14462       -3     
- Misses      10888    10889       +1     
- Partials      701      703       +2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.91% <ø> (+<0.01%) ⬆️ Carriedforward from c753de5
e2e-stable 57.30% <ø> (+0.07%) ⬆️
unit 49.06% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2c8b3...8a62003. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Sep 18, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/22/2023 01:18:57pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 8a62003

Started: 09/22/2023 01:16:46pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 139 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/22/2023 01:18:57pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 8a62003

Started: 09/22/2023 01:05:24pm UTC

⚠️ Flakes

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
0.92% (1) 1 / 109 run
failed over last 7 days
11.01% (12) 12 / 109 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.33% (1) 1 / 75 run
failed over last 7 days
82.67% (62) 62 / 75 runs
flaked over last 7 days

View Detailed Build Results


@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Sep 18, 2023

Looks great. Let's try this on a real dataset.

We can update the readme to simply match what you've provided in the PR Comments

Let's be very explicit and make individual package scripts.

deleteAnnotations:openmct
deleteAnnotations:openmct:all
deleteAnnotations:openmct:pixel_spatial
deleteAnnotations:openmct:blah
deleteAnnotations:openmct:blah

@scottbell scottbell marked this pull request as ready for review September 18, 2023 21:00
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 20, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 20, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@unlikelyzero
Copy link
Collaborator

@scottbell can you figure out why functional/plugins/displayLayout/displayLayout.e2e.spec.js is now failing more frequently

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@scottbell
Copy link
Contributor Author

@scottbell can you figure out why functional/plugins/displayLayout/displayLayout.e2e.spec.js is now failing more frequently

Could you please point me to the build failure? I'm not seeing it in this PR

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@scottbell
Copy link
Contributor Author

scottbell commented Sep 21, 2023

@scottbell can you figure out why functional/plugins/displayLayout/displayLayout.e2e.spec.js is now failing more frequently

Could you please point me to the build failure? I'm not seeing it in this PR

@unlikelyzero This Couch one?

1) [chrome] › functional/plugins/displayLayout/displayLayout.e2e.spec.js:260:3 › Display Layout › When multiple plots are contained in a layout, we only ask for annotations once @couchdb 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

      331 |
      332 |     // In real time mode, we don't fetch annotations at all
    > 333 |     expect(networkRequests.length).toBe(0);
          |                                    ^
      334 |   });
      335 | });
      336 |

        at /home/runner/work/openmct/openmct/e2e/tests/functional/plugins/displayLayout/displayLayout.e2e.spec.js:333:36

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@scottbell
Copy link
Contributor Author

@scottbell can you figure out why functional/plugins/displayLayout/displayLayout.e2e.spec.js is now failing more frequently

Could you please point me to the build failure? I'm not seeing it in this PR

@unlikelyzero This Couch one?

1) [chrome] › functional/plugins/displayLayout/displayLayout.e2e.spec.js:260:3 › Display Layout › When multiple plots are contained in a layout, we only ask for annotations once @couchdb 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

      331 |
      332 |     // In real time mode, we don't fetch annotations at all
    > 333 |     expect(networkRequests.length).toBe(0);
          |                                    ^
      334 |   });
      335 | });
      336 |

        at /home/runner/work/openmct/openmct/e2e/tests/functional/plugins/displayLayout/displayLayout.e2e.spec.js:333:36

I figured it out @unlikelyzero. It's because we debounce the URL navigator, so switching to real-time mode (which is required for this test to work) isn't always saved in time in the URL. If it hasn't switched by the time we get to the reload, we're still in fixed-time mode, and we ask for annotations.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 22, 2023
@unlikelyzero unlikelyzero merged commit ce23054 into master Sep 25, 2023
18 checks passed
@unlikelyzero unlikelyzero deleted the 7056-couchdb-add-couchdb-scripts-to-repo branch September 25, 2023 17:15
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CouchDB] Add couchdb scripts to repo
2 participants