Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#7065): Have annotations work with domain objects that ha… #7078

Merged
merged 1 commit into from Sep 21, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Sep 21, 2023

…ve dots

Issue #7063

  • migrating to new structure - wip

  • notebooks work, now to plots and images

  • resolve conflicts

  • fix search

  • add to readme

  • spelling

  • fix unit test

  • add search by view for big search speedup

  • spelling

  • fix out of order search

  • improve reliability of plot tagging tests

…ve dots

* migrating to new structure - wip

* notebooks work, now to plots and images

* resolve conflicts

* fix search

* add to readme

* spelling

* fix unit test

* add search by view for big search speedup

* spelling

* fix out of order search

* improve reliability of plot tagging tests
@ozyx ozyx added this to the Target:3.0.2 milestone Sep 21, 2023
@deploysentinel
Copy link

deploysentinel bot commented Sep 21, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ❌ 1 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/21/2023 10:02:38pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: c5bfff1

Started: 09/21/2023 09:57:40pm UTC

❌ Failures

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2Retry 1Initial Attempt
Error: expect(received).toBe(expected) // Object.is equality...
expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1
9.52% (6) 6 / 63 runs
failed over last 7 days
34.92% (22) 22 / 63 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 138 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/21/2023 10:02:38pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c5bfff1

Started: 09/21/2023 09:56:40pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 130 runs
failed over last 7 days
44.62% (58) 58 / 130 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.54% (2) 2 / 130 runs
failed over last 7 days
38.46% (50) 50 / 130 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.23% (2) 2 / 162 runs
failed over last 7 days
51.23% (83) 83 / 162 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/3.0.2@af4ef8c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/3.0.2    #7078   +/-   ##
================================================
  Coverage                 ?   55.39%           
================================================
  Files                    ?      650           
  Lines                    ?    25937           
  Branches                 ?     2535           
================================================
  Hits                     ?    14369           
  Misses                   ?    10872           
  Partials                 ?      696           
Flag Coverage Δ *Carryforward flag
e2e-full 42.03% <0.00%> (?) Carriedforward from f705bf9
e2e-stable 56.39% <0.00%> (?)
unit 49.13% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4ef8c...c5bfff1. Read the comment docs.

@shefalijoshi shefalijoshi merged commit d4e2716 into release/3.0.2 Sep 21, 2023
12 of 17 checks passed
@shefalijoshi shefalijoshi deleted the cherry-pick-7065 branch September 21, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants