Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite loop when updating a table row in place #7154

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Oct 20, 2023

Closes akhenry/openmct-yamcs#384

Describe your changes:

When updating a row in place, we need to be sure to bump the incomingRowIndex so we don't have an infinite loop.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 20, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/23/2023 10:51:18am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: a8294a1

Started: 10/23/2023 10:46:33am UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 144 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/23/2023 10:51:18am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: a8294a1

Started: 10/23/2023 10:45:22am UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
6.67% (4) 4 / 60 runs
failed over last 7 days
45% (27) 27 / 60 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
3.45% (2) 2 / 58 runs
failed over last 7 days
29.31% (17) 17 / 58 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.12% (1) 1 / 89 run
failed over last 7 days
50.56% (45) 45 / 89 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #7154 (e4bad32) into master (2daec44) will decrease coverage by 13.79%.
The diff coverage is n/a.

❗ Current head e4bad32 differs from pull request most recent head a8294a1. Consider uploading reports for the commit a8294a1 to get more accurate results

@@             Coverage Diff             @@
##           master    #7154       +/-   ##
===========================================
- Coverage   55.62%   41.84%   -13.79%     
===========================================
  Files         651      414      -237     
  Lines       26186    12920    -13266     
  Branches     2535        0     -2535     
===========================================
- Hits        14566     5406     -9160     
+ Misses      10914     7514     -3400     
+ Partials      706        0      -706     
Flag Coverage Δ
e2e-full 41.84% <ø> (+0.03%) ⬆️
e2e-stable ?
unit ?
Files Coverage Δ
...s/telemetryTable/collections/TableRowCollection.js 1.62% <ø> (-62.41%) ⬇️

... and 521 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2daec44...a8294a1. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 20, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 20, 2023
@ozyx ozyx added this to the Target:3.2.0 milestone Oct 20, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 23, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 23, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! LGTM

@ozyx ozyx merged commit 13311b9 into master Oct 23, 2023
21 checks passed
@ozyx ozyx deleted the 384-sorting-the-command-history-table-causes-open-mct-to-freeze branch October 23, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting the command history table causes Open MCT to freeze
2 participants