Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DisplayLayout and FlexibleLayout toolbar actions only apply to selected layout #7184

Merged
merged 25 commits into from
Nov 2, 2023
Merged

fix: DisplayLayout and FlexibleLayout toolbar actions only apply to selected layout #7184

merged 25 commits into from
Nov 2, 2023

Commits on Oct 27, 2023

  1. WIP

    @ozyx
    ozyx committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    14983ea View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. refactor: convert to ES6 function

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3c38eb7 View commit details
    Browse the repository at this point in the history

  2. fix: include keyString in event name 

    - This negates the need for complicated logic in determining which objectView the action was intended for
    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    43ea6cd View commit details
    Browse the repository at this point in the history

  3. fix: handle the case of currentView being null

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2426f1f View commit details
    Browse the repository at this point in the history

  4. fix: add keyString to flexibleLayout toolbar events

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    88fbdbe View commit details
    Browse the repository at this point in the history

  5. fix: properly unregister listeners

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3f7fcd1 View commit details
    Browse the repository at this point in the history

  6. fix: remove unused imports

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e717bec View commit details
    Browse the repository at this point in the history

  7. fix: revert parameter reorder

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    42a4de8 View commit details
    Browse the repository at this point in the history

  8. refactor: replace usage of arguments with ...args

    @ozyx
    ozyx committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b5cc12c View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. fix: add a11y to display layout + toolbar

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0c0b478 View commit details
    Browse the repository at this point in the history

  2. test: add first cut of layout toolbar suite

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    09e52c1 View commit details
    Browse the repository at this point in the history

  3. test: cleanup a bit and add Image test

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8fe50fa View commit details
    Browse the repository at this point in the history

  4. test: add stubs

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fc58177 View commit details
    Browse the repository at this point in the history

  5. fix: remove unused variable

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    823ae28 View commit details
    Browse the repository at this point in the history

  6. refactor(DisplayLayoutToolbar): convert to ES6 class

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a15aa52 View commit details
    Browse the repository at this point in the history

  7. test: generate localStorage data for display layout tests

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    dc50deb View commit details
    Browse the repository at this point in the history

  8. fix: clarify "Add" button label

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e006906 View commit details
    Browse the repository at this point in the history

  9. test: cleanup and don't parameterize tests

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    265b3e8 View commit details
    Browse the repository at this point in the history

  10. test: fix path for recycled_local_storage.json

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ec33110 View commit details
    Browse the repository at this point in the history

  11. fix: path to local storage file

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8235e58 View commit details
    Browse the repository at this point in the history

  12. docs: add documentation for 

    utilizing localStorage in e2e
    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1cf41d1 View commit details
    Browse the repository at this point in the history

  13. fix: path to recycled_local_storage.json

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    865ba77 View commit details
    Browse the repository at this point in the history

  14. docs: add note hyperlink

    @ozyx
    ozyx committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    825365c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'master' into mct7176

    @scottbell
    scottbell committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cf43623 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mct7176

    @ozyx
    ozyx committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f58465d View commit details
    Browse the repository at this point in the history