Provide visibility based rendering as part of the view api #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/20/2023 05:18:42pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Tagging in Notebooks @addinit Tags persist across reload
Retry 1 • Initial Attempt |
0% (0)0 / 57 runsfailed over last 7 days |
3.51% (2)2 / 57 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.69% (1)1 / 59 runfailed over last 7 days |
61.02% (36)36 / 59 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
3.61% (3)3 / 83 runsfailed over last 7 days |
62.65% (52)52 / 83 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
3.33% (2)2 / 60 runsfailed over last 7 days |
25% (15)15 / 60 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
1.67% (1)1 / 60 runfailed over last 7 days |
70% (42)42 / 60 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/20/2023 05:18:42pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: ecd6bb9
Started: 11/20/2023 05:11:16pm UTC
⚠️ Flakes
📄 functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
0% (0)0 / 33 runsfailed over last 7 days |
15.15% (5)5 / 33 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7241 +/- ##
===========================================
- Coverage 56.04% 41.87% -14.18%
===========================================
Files 654 417 -237
Lines 26227 12997 -13230
Branches 2527 0 -2527
===========================================
- Hits 14700 5442 -9258
+ Misses 10829 7555 -3274
+ Partials 698 0 -698
... and 520 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-part-of-the-view-api
scottbell
requested review from
akhenry and
ozyx
and removed request for
akhenry
ozyx
requested changes
Nov 17, 2023
ozyx
approved these changes
Nov 20, 2023
akhenry
approved these changes
Nov 20, 2023
…-part-of-the-view-api
unlikelyzero
deleted the
7235-provide-visibility-based-rendering-as-part-of-the-view-api
branch
scottbell
added a commit
that referenced
this pull request
Nov 20, 2023
* first draft * in preview mode, just show it * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7235
Describe your changes:
When showing a View, pass an optional function that Views can use to call
requestAnimationFrameonly when the View is visible.All Submissions:
Author Checklist
Reviewer Checklist