chore: bump d3-scale and use ESModule imports
#7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/28/2023 09:24:15pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 22 runsfailed over last 7 days |
22.73% (5)5 / 22 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
0% (0)0 / 22 runsfailed over last 7 days |
31.82% (7)7 / 22 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 22 runsfailed over last 7 days |
63.64% (14)14 / 22 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
+ Coverage 56.01% 56.14% +0.12%
==========================================
Files 654 654
Lines 26229 26229
Branches 2528 2528
==========================================
+ Hits 14691 14725 +34
+ Misses 10831 10803 -28
+ Partials 707 701 -6
*This pull request uses carry forward flags. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/A
Describe your changes:
Bumps the d3-scale version to 4.0.2 which allows us to use ESModule imports. These are tree-shakable and should pare down the package size a bit. Also gets rid of one
npm auditwarning.All Submissions:
Author Checklist
Reviewer Checklist