-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cspell): grammar fixes #7735
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7735 +/- ##
==========================================
- Coverage 56.96% 56.64% -0.33%
==========================================
Files 673 673
Lines 27177 27177
Branches 2636 2636
==========================================
- Hits 15482 15394 -88
- Misses 11364 11452 +88
Partials 331 331
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ozyx I want to hand over this PR to you. There's variables in the source code that needs to be changed, and I think that someone that's working with the code actively should make sure the "meta" logic is intact |
You can go ahead and change it and we can catch it in the code review. That would work better for us. Thanks again for taking this on! |
@ozyx PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, it's almost there! I found a few other typos that should be removed from cspell.json
and updated in the codebase. I think this should be good to go once those are fixed.
Fixed! 😄 |
CC @ozyx |
@ozyx wanna have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Just a couple more changes and LGTM
PTAL @ozyx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM
Closes #7440
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist