Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cspell): grammar fixes #7735

Merged
merged 7 commits into from
Jul 1, 2024
Merged

chore(cspell): grammar fixes #7735

merged 7 commits into from
Jul 1, 2024

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented May 21, 2024

Closes #7440

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

.cspell.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (393da7d) to head (ef03bf1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7735      +/-   ##
==========================================
- Coverage   56.96%   56.64%   -0.33%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15482    15394      -88     
- Misses      11364    11452      +88     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.57% <20.00%> (-18.25%) ⬇️
e2e-stable 60.61% <80.00%> (-0.01%) ⬇️
unit 49.25% <50.00%> (-0.04%) ⬇️
Files Coverage Δ
src/api/overlays/Dialog.js 100.00% <ø> (ø)
src/api/overlays/Overlay.js 94.44% <100.00%> (ø)
src/api/overlays/ProgressDialog.js 100.00% <ø> (ø)
src/api/overlays/Selection.js 100.00% <ø> (ø)
src/api/telemetry/TelemetryAPI.js 89.38% <ø> (ø)
src/api/user/StoragePersistence.js 100.00% <ø> (ø)
src/api/user/UserAPI.js 81.08% <100.00%> (ø)
src/plugins/licenses/plugin.js 100.00% <ø> (ø)
src/plugins/notebook/components/NotebookEmbed.vue 0.00% <ø> (ø)
...ficationIndicator/components/NotificationsList.vue 0.00% <ø> (ø)
... and 4 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393da7d...ef03bf1. Read the comment docs.

@evenstensberg
Copy link
Contributor Author

@ozyx I want to hand over this PR to you. There's variables in the source code that needs to be changed, and I think that someone that's working with the code actively should make sure the "meta" logic is intact

@ozyx
Copy link
Member

ozyx commented May 30, 2024

@ozyx I want to hand over this PR to you. There's variables in the source code that needs to be changed, and I think that someone that's working with the code actively should make sure the "meta" logic is intact

You can go ahead and change it and we can catch it in the code review. That would work better for us. Thanks again for taking this on!

@evenstensberg evenstensberg marked this pull request as ready for review June 4, 2024 11:56
@evenstensberg
Copy link
Contributor Author

@ozyx PTAL

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jun 4, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Jun 4, 2024
src/api/user/UserAPI.js Show resolved Hide resolved
src/api/user/StoragePersistance.js Outdated Show resolved Hide resolved
@evenstensberg evenstensberg requested a review from ozyx June 4, 2024 17:12
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 5, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, it's almost there! I found a few other typos that should be removed from cspell.json and updated in the codebase. I think this should be good to go once those are fixed.

.cspell.json Outdated Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
e2e/tests/framework/exampleTemplate.e2e.spec.js Outdated Show resolved Hide resolved
.cspell.json Show resolved Hide resolved
@evenstensberg evenstensberg requested a review from ozyx June 5, 2024 19:03
@evenstensberg
Copy link
Contributor Author

Fixed! 😄

@evenstensberg
Copy link
Contributor Author

CC @ozyx

@evenstensberg
Copy link
Contributor Author

@ozyx wanna have a look?

Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Just a couple more changes and LGTM

.cspell.json Outdated Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
src/api/telemetry/TelemetryAPISpec.js Show resolved Hide resolved
@evenstensberg
Copy link
Contributor Author

PTAL @ozyx

@ozyx ozyx self-requested a review July 1, 2024 16:04
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jul 1, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@ozyx ozyx merged commit 291c099 into nasa:master Jul 1, 2024
31 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mispellings from our cspell dictionary
2 participants