Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addressability] Use/populate URL #8

Merged
merged 15 commits into from
Jun 19, 2015
Merged

[Addressability] Use/populate URL #8

merged 15 commits into from
Jun 19, 2015

Conversation

VWoeltjen
Copy link
Contributor

Use and populate URL for domain objects. Specifically:

  • In Browse mode, follow the path of IDs to determine initial navigation state.
  • Also use "view" query string parameter to select the current view
  • Update both of the above to reflect changes during use
  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? Y
  3. Command line build passes? Y
  4. Expect to pass code review? Y
  5. Project-specific information isolated to appropriate branches? Y

@VWoeltjen
[Addressability] Get IDs from URL
f24db15 
Add a route parameter to Browse mode which includes domain
object identifiers. WTD-1149.
@VWoeltjen
[Addressability] Navigate down path from params
8f18d88 
Traverse down the path from route parameters to initially navigate to a
domain object in Browse mode. WTD-1149.
@VWoeltjen
[Addressability] Infer ROOT
9fae2db 
Treat the path element for the root domain object as implicit, such
that it does not appear in the full URL. WTD-1149.
@VWoeltjen
[Addressability] Update path on navigation
084d6b6 
Update path in browse mode when navigation state changes.
WTD-1149.
@VWoeltjen
[Addressability] Update route without reinstantiating
3738ea1 
Work around normal behavior of Angular when path changes;
instead of reinstantiating controller for Browse mode
when Browse-initiated path changes occur, act as if the
route hadn't changed (so that the URL updates but the
currently-displayed state, e.g. tree expansion, is
preserved.) WTD-1149.
@VWoeltjen
[Addressability] Preserve nav. state on leaving Edit
d7b79b6 
Preserve navigation state when leaving Edit mode, in the context
of addressability changes. WTD-1149.
@VWoeltjen
[Addressability] Handle bad paths
26fd56a 
Handle paths that cannot be completely followed, WTD-1149.
@VWoeltjen
[Addressability] Obey view query string param
fec6f06 
Obey the query string parameter for a view, if present.
WTD-1149.
@VWoeltjen
[Addressability] Expose current view in query param
d559dae 
Expose the currently selected view as a query string parameter,
WTD-1149.
@VWoeltjen
[Addressability] Work around reload again
9942e24 
Work around Angular's page refresh on URL change to avoid
unintended effects when chosen view changes (such as tree
collapse), WTD-1149.
@VWoeltjen
[Addressability] Update spec for BrowseController
699cd3b 
Update spec to reflect changes for BrowseController to support
addressability of domain objects, WTD-1149.
@VWoeltjen
[Addressability] Remove excessive check
bcb4e9c 
Remove unneeded check from ViewSwitcherController; not necessary
to avoid overwriting query string selection of view. WTD-1149.
@VWoeltjen
[Addressability] Add test cases
c1c633d 
Add test cases to BrowseController which reflect changes for
addressability, WTD-1149.
@VWoeltjen
[Addressability] Add spec for BrowseObjectController
5849f8a 
Add spec for BrowseObjectController, added to track current
view selection from/to query string params, WTD-1149.
@VWoeltjen
[Addressability] Fix code style
ee69eb3 
Change code style to satisfy JSLint for changes from WTD-1149.
@VWoeltjen VWoeltjen mentioned this pull request Jun 18, 2015
Closed
@charlesh88
Copy link
Contributor

Review Checklist
Changes appear to address issue? Y
Appropriate unit tests included? Y (Jasmine at 99.47%)
Code style and in-line documentation are appropriate? Y
Commit messages meet standards? Y
Project-specific information isolated to appropriate branches? Y

@charlesh88 charlesh88 assigned VWoeltjen and unassigned charlesh88 Jun 19, 2015
VWoeltjen added a commit that referenced this pull request Jun 19, 2015
@VWoeltjen
Merge pull request #8 from nasa/open1149
6b0a77d 
[Addressability] Use/populate URL
@VWoeltjen VWoeltjen merged commit 6b0a77d into master Jun 19, 2015
@VWoeltjen VWoeltjen deleted the open1149 branch June 19, 2015 23:05
@VWoeltjen
Copy link
Contributor Author

Integration Checklist

  1. Automated build passing after merge? Y
  2. No merge conflicts (or resolution trivial/obvious)? Y
  3. All master branches up-to-date after merge? Y
  4. Project-specific information isolated to appropriate branches? Y

@charlesh88 charlesh88 mentioned this pull request Jan 11, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VWoeltjen VWoeltjen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VWoeltjen @charlesh88