Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network-api-test timeout still too short for MCP750 #1086

Closed
jphickey opened this issue Jun 25, 2021 · 2 comments · Fixed by #1092 or #1098
Closed

network-api-test timeout still too short for MCP750 #1086

jphickey opened this issue Jun 25, 2021 · 2 comments · Fixed by #1092 or #1098
Assignees
@jphickey
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage) vxworks
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Describe the bug
The console/printf operations on MCP750 take a considerable amount of time (only 9600 baud serial). It appears some extra assert statements added in this test have made it so even 1000ms is not sufficient. (looks like the ServerFn might be timing out on a write while the client is printing a bunch of asserts, which then causes an error later when the client finally gets to the read).

To Reproduce
Run test on MCP750, observe unexpected timeout error:

[ FAIL] 04.040 network-api-test.c:680 - OS_TimedRead() (-4) == 4

Expected behavior
Test should pass

System observed on:
MCP750 VxWorks 6.9

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 25, 2021
@jphickey jphickey added the bug label Jun 25, 2021
@jphickey
Copy link
Contributor Author

Bumping the timeout up to 4000ms seems to fix the issue.... so this is what I'd propose.

@skliper skliper added this to the 6.0.0 milestone Jun 25, 2021
@skliper
Copy link
Contributor

skliper commented Jun 25, 2021

Concur.

jphickey added a commit to jphickey/osal that referenced this issue Jun 25, 2021
@jphickey
Fix nasa#1086, increase timeout in network-api-test
55cb7b2 
The number of asserts being printed was still taking longer than 1000ms
on a 9600 baud serial link, so increasing the timeout allows tests to
pass.
@jphickey jphickey mentioned this issue Jun 25, 2021
Merged
@jphickey jphickey added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jun 25, 2021
astrogeco added a commit that referenced this issue Jul 2, 2021
@astrogeco
Merge pull request #1092 from jphickey/fix-1086-network-api-timeout
931c469 
Fix #1086, increase timeout in network-api-test
@astrogeco astrogeco mentioned this issue Jul 2, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1086 from skliper/fix904-cpuname_doc
8559cf3 
Fix nasa#904, Update cpuname targets.cmake documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage) vxworks
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco