osal Integration candidate: 2021-06-29 #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To account for potential of imprecise timing/clock sampling when running on a VM, allow for a wider range of time values to pass the test.
Ensures that OS_GetTaskId_Impl() returns OS_OBJECT_ID_UNDEFINED if called from the root task - as this does not have an OSAL task ID.
The number of asserts being printed was still taking longer than 1000ms on a 9600 baud serial link, so increasing the timeout allows tests to pass.
In the osal_core_UT test, the test task was being deleted while it was in the midst of a UtPrintf call, which left the BSP mutex in a locked state, causing deadlock. Using SEM_DELETE_SAFE attribute avoids task deletion for the mutex holder, and adding a small delay to the test case makes all the messages appear as expected (accounts for slow serial console on test platform).
For the MCP750, the symbol table fairly large and requires a considerably larger limit to avoid the OS_ERR_OUTPUT_TOO_LARGE limit. This also uses a different name, so that the user can actually see the symbol dump file if they want (otherwise the next test overwrites the file).
Skip the registration of a timer in VxWorks when the assigned_signal is 0 (this indicates an external sync function is used).
Fix #1080, add range to OS_TaskDelay checks
Fix #1084, root task ID on RTEMS
Fix #1082, increase UT symbol dump size limit
Fix #1087, do not register RTOS timer for external sync
Fix #1088, avoid task delete during UtPrintf
Fix #1096, Add OSAL prefix to Network API group
Fix #1086, increase timeout in network-api-test
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2021
**Combines:** nasa/osal#1098 **Includes:** nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, root task ID on RTEMS nasa/osal#1090, increase timeout in network-api-test nasa/osal#1091, avoid task delete during UtPrintf nasa/osal#1093, increase UT symbol dump size limit nasa/osal#1097, do not register RTOS timer for external sync nasa/osal#1092, Add osal# prefix to Network API group
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2021
**Combines:** nasa/osal#1098 **Includes:** nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS nasa/osal#1090, increase UT symbol dump size limit nasa/osal#1091, do not register RTOS timer for external sync nasa/osal#1093, avoid task delete during UtPrintf nasa/osal#1097, Add osal prefix to Network API group nasa/osal#1092, increase timeout in network-api-test
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2021
**Combines** nasa/cFE#1654, cfe v6.8.0-rc1+dev739 nasa/osal#1098, osal v5.1.0-rc1+dev564 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests. nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS nasa/osal#1090, increase UT symbol dump size limit nasa/osal#1091, do not register RTOS timer for external sync nasa/osal#1093, avoid task delete during UtPrintf nasa/osal#1097, Add osal prefix to Network API group nasa/osal#1092, increase timeout in network-api-test Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Himanshu <himanshu007-creator@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#287
Tests
https://github.com/nasa/cfs/pull/287/checks
https://github.com/nasa/osal/pull/1098/checks
Authors
@jphickey
@skliper
Description
PR #1081
Fix #1080, add range to OS_TaskDelay checks
PR #1085
Fix #1084, Return
OS_OBJECT_ID_UNDEFINEDfor root task ID on RTEMSPR #1090
Fix #1082, increase UT symbol dump size limit
PR #1091
Fix #1087, do not register RTOS timer for external sync
PR #1093
Fix #1088, avoid task delete during UtPrintf
PR #1097
Fix #1096, Add osal prefix to Network API group
PR #1092
Fix #1086, increase timeout in network-api-test