Fix #1083, timer reconfig tests #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying OS mechanism that rejects calls to timer APIs from timer callbacks does not work on anything except POSIX. This skips these unit tests on non-POSIX platforms, and also adds documentation clearly indicating that the API must not be called from a timer context.
jphickey
added
the
CCB:Ready
skliper
requested changes
Jun 28, 2021
pepepr08
approved these changes
Jun 28, 2021
astrogeco
added
CCB:Approved
|
CCB:2021-06-30 APPROVED
|
|
Updated comment in commit 9a46055, should be OK to merge now. |
jphickey
force-pushed
the
fix-1083-reconfig-test
branch
from
9a46055
to
8615fe8
Compare
|
Updated again to include why only POSIX_OS is checked (missed that the first time). Should be good now, for real. |
Per review feedback, removes comment that was stale and no longer valid, and describe why only POSIX_OS is enabled here on this check.
jphickey
force-pushed
the
fix-1083-reconfig-test
branch
from
8615fe8
to
a8db3cd
Compare
|
Commit a8db3cd only corrects whitespace for format check |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 12, 2021
nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
This was referenced Jul 12, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The underlying OS mechanism that rejects calls to timer APIs from timer callbacks does not work on anything except POSIX. This skips these unit tests on non-POSIX platforms, and also adds documentation clearly indicating that the API must not be called from a timer context.
Fixes #1083
Testing performed
Run unit tests
Expected behavior changes
Test now passes because this check is skipped on these platforms
System(s) tested on
MCP750 / VxWorks 6.9
QEMU / RTEMS 4.11
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.