Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osal Integration candidate: Equuleus-rc1+dev5 #1451

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Conversation

dzbaker
Copy link
Collaborator

@dzbaker dzbaker commented Feb 22, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
cFS Bundle Checks
osal Checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu 20.04

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@thesamprice
@thnkslprpt

Sam Price and others added 6 commits January 20, 2023 14:45
Use the "virtual_path" instead of "device_name" as the name
record for FS_BASED entries.  This should allow duplicate
detection to work as expected.

The device_name on mappings made via this method will now be
an empty string.  It is not relevant because this type of map
is used for devices that are already mounted.
Fix #1433, use virtual path as name for FS_BASED maps
src/os/posix/src/os-impl-tasks.c Fixed Show fixed Hide fixed
src/os/posix/src/os-impl-tasks.c Fixed Show fixed Hide fixed
Fix #1452, Remove softsleep, as a dead store.
…ng-goto

Fix #1356, Remove stray remaining 'goto' in OSAL test code
…-parameter-names

Fix #1353, Align mismatched function prototype/implem. parameter names
…mid-function

Fix #1330, Move variables declared mid-function to the top
@@ -296,28 +296,28 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_ModuleInfo(osal_id_t module_id, OS_module_prop_t *module_prop)
int32 OS_ModuleInfo(osal_id_t module_id, OS_module_prop_t *module_info)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -420,7 +420,7 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_SymbolTableDump(const char *filename, size_t SizeLimit)
int32 OS_SymbolTableDump(const char *filename, size_t size_limit)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -331,29 +331,29 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_SymbolLookup(cpuaddr *SymbolAddress, const char *SymbolName)
int32 OS_SymbolLookup(cpuaddr *symbol_address, const char *SymbolName)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -1358,7 +1358,7 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
void OS_ForEachObjectOfType(osal_objtype_t idtype, osal_id_t creator_id, OS_ArgCallback_t callback_ptr,
void OS_ForEachObjectOfType(osal_objtype_t objtype, osal_id_t creator_id, OS_ArgCallback_t callback_ptr,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -126,7 +126,7 @@
* See prototype for argument/return detail
*
*-----------------------------------------------------------------*/
int32 OS_FileStat_Impl(const char *local_path, os_fstat_t *FileStats)
int32 OS_FileStat_Impl(const char *local_path, os_fstat_t *filestat)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -90,7 +90,7 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_TimeBaseCreate(osal_id_t *timer_id, const char *timebase_name, OS_TimerSync_t external_sync)
int32 OS_TimeBaseCreate(osal_id_t *timebase_id, const char *timebase_name, OS_TimerSync_t external_sync)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -197,10 +197,10 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_TimerAdd(osal_id_t *timer_id, const char *timer_name, osal_id_t timebase_ref_id, OS_ArgCallback_t callback_ptr,
int32 OS_TimerAdd(osal_id_t *timer_id, const char *timer_name, osal_id_t timebase_id, OS_ArgCallback_t callback_ptr,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -226,7 +226,8 @@
* See description in API and header file for detail
*
*-----------------------------------------------------------------*/
int32 OS_TimerCreate(osal_id_t *timer_id, const char *timer_name, uint32 *accuracy, OS_TimerCallback_t callback_ptr)
int32 OS_TimerCreate(osal_id_t *timer_id, const char *timer_name, uint32 *clock_accuracy,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -1368,7 +1368,7 @@
filter.user_callback = callback_ptr;
filter.user_arg = callback_arg;

if (OS_ObjectIdIteratorInit(OS_ForEachFilterCreator, &filter, idtype, &iter) == OS_SUCCESS)
if (OS_ObjectIdIteratorInit(OS_ForEachFilterCreator, &filter, objtype, &iter) == OS_SUCCESS)

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.
@@ -126,7 +126,7 @@
* See prototype for argument/return detail
*
*-----------------------------------------------------------------*/
int32 OS_FileStat_Impl(const char *local_path, os_fstat_t *FileStats)
int32 OS_FileStat_Impl(const char *local_path, os_fstat_t *filestat)

Check notice

Code scanning / CodeQL

Function too long Note

OS_FileStat_Impl has too many lines (82, while 60 are allowed).
@dzbaker dzbaker merged commit 53550ca into main Feb 23, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants