-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1455, High-res timed stream ops #1456
Conversation
4dfb405
to
5ad9c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
5ad9c53
to
8dfdbda
Compare
Add API calls equivalent to existing calls that use an absolute timeout as opposed to a relative timeout. The absolute timeout can support resolution of 0.1 usec in the default configuration. Internally this primarily affects the underlying call to select(). Note that per the definition of select() in POSIX, it uses a "struct timeval" which has a resolution of 1 usec.
8dfdbda
to
ec30aa7
Compare
Updated to expose the high-res API ("Abs" timeout variant) on the following additional OSAL calls:
The existing (relative timeout) variant becomes a wrapper around the Abs timeout version above. |
Fix #1455, High-res timed stream ops
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
…e incorrect status variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
*Combines:* cFE equuleus-rc1+dev167 osal equuleus-rc1+dev81 **Includes:** *cFE* - nasa/cFE#2560 *osal* - nasa/osal#1456 - nasa/osal#1465 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
*Combines:* cFE equuleus-rc1+dev167 osal equuleus-rc1+dev81 **Includes:** *cFE* - nasa/cFE#2560 *osal* - nasa/osal#1456 - nasa/osal#1465 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
Checklist (Please check before submitting)
Describe the contribution
Implement high-res timed operations for streams. This uses an absolute time via the OS_time_t value, which has a default resolution of 0.1usec but is configurable.
Fixes #1455
Testing performed
Full suite of coverage and functional tests
Expected behavior changes
New APIs added, does not change existing APIs
System(s) tested on
Debian
Additional context
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.