Fix #1455, High-res timed stream ops #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-1455-hires-timedops
branch
2 times, most recently
from
4dfb405
to
5ad9c53
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
force-pushed
the
fix-1455-hires-timedops
branch
from
5ad9c53
to
8dfdbda
Compare
jphickey
changed the title
jphickey
added
the
CCB:Ready
Add API calls equivalent to existing calls that use an absolute timeout as opposed to a relative timeout. The absolute timeout can support resolution of 0.1 usec in the default configuration. Internally this primarily affects the underlying call to select(). Note that per the definition of select() in POSIX, it uses a "struct timeval" which has a resolution of 1 usec.
jphickey
force-pushed
the
fix-1455-hires-timedops
branch
from
8dfdbda
to
ec30aa7
Compare
|
Updated to expose the high-res API ("Abs" timeout variant) on the following additional OSAL calls:
The existing (relative timeout) variant becomes a wrapper around the Abs timeout version above. |
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Jul 2, 2024
Fix #1455, High-res timed stream ops
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
…e incorrect status variable.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 2, 2024
*Combines:* cFE equuleus-rc1+dev137 osal equuleus-rc1+dev66 elf2cfetbl equuleus-rc1+dev56 **Includes:** *cFS* - #707 - #773 *cFE* - nasa/cFE#2560 - nasa/cFE#2344 - nasa/cFE#2359 - nasa/cFE#2376 - nasa/cFE#2496 - nasa/cFE#2554 - nasa/cFE#2568 - nasa/cFE#2566 *osal* - nasa/osal#1456 - nasa/osal#1465 *elf2cfetbl* - nasa/elf2cfetbl#147 - nasa/elf2cfetbl#124 - nasa/elf2cfetbl#125 - nasa/elf2cfetbl#127 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Anh Van <avan989@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 15, 2024
*Combines:* cFE equuleus-rc1+dev167 osal equuleus-rc1+dev81 **Includes:** *cFE* - nasa/cFE#2560 *osal* - nasa/osal#1456 - nasa/osal#1465 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 15, 2024
*Combines:* cFE equuleus-rc1+dev167 osal equuleus-rc1+dev81 **Includes:** *cFE* - nasa/cFE#2560 *osal* - nasa/osal#1456 - nasa/osal#1465 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Implement high-res timed operations for streams. This uses an absolute time via the OS_time_t value, which has a default resolution of 0.1usec but is configurable.
Fixes #1455
Testing performed
Full suite of coverage and functional tests
Expected behavior changes
New APIs added, does not change existing APIs
System(s) tested on
Debian
Additional context
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.