Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oceanwater 975 limit system faults publish rate #341

Conversation

anthonykoutroulis
Copy link
Member

Linked Issues:

| Jira Ticket 🎟️ | OCEANWATER-975 |

Summary of Changes

  • Have the Joint Faults module subscribe to the original Joint States message, rather than just the gazebo sim updates.
  • Change the /flags/joint_states publishing to happen as Joint States messages are received (same rate), rather than on every update
  • Flags are still internally updated at sim time.
  • Fault detector unchanged, but now /system_faults_status publishes at the correct 50Hz, corresponding to the rate the lander updates rather than as fast as it can to keep up with gazebo sim ticks (was ~400Hz)

Test

  • Run a scenario, ie: roslaunch ow atacama_y1a.launch
  • In another terminal, monitor the system faults message content: rostopic echo /system_faults_status
  • In another terminal, monitor the system faults message rate: rostopic hz /system_faults_status
  • Observe a fault value of value: 0 (no faults), and a topic rate of 50Hz
  • In the rqt_gui, activate an arm fault: Dynamic Reconfigure -> faults -> arm_faults
  • Observe the fault value updates correctly: value: 4

@anthonykoutroulis anthonykoutroulis changed the base branch from master to noetic-devel June 1, 2023 17:48
@anthonykoutroulis anthonykoutroulis marked this pull request as ready for review June 1, 2023 17:49
Copy link
Contributor

@kmdalal kmdalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed, looks good!

@anthonykoutroulis anthonykoutroulis merged commit 9a061bf into noetic-devel Jun 6, 2023
@anthonykoutroulis anthonykoutroulis deleted the OCEANWATER-975-limit-system-faults-publish-rate branch June 6, 2023 18:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants