Ic 20200304 #36
Merged
Ic 20200304 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a single struct for the SCH_LAB globals adds namespace protection and is consistent with the way other CFE modules do this.
Use a union type to allocate the message buffers to ensure it is aligned properly for a CFE_SB_Msg_t type.
Simplify the SCH_LAB table definition: - Do not use "aux_source_directory" which will also pull in the table file (table file should not be built w/source) - Make an "entry" structure that only has the MessagID and Rate/Period - Put runtime data (count) in a runtime struct, not the table - Popluate the runtime config from the table and then release the table - Delete the validation function - not used here - example should be in the sample_app. - No need to use "END_OF_TABLE" marker - tables are always fixed length and a rate of "0" is sufficient to identify an unconfigured entry. - Make no attempt to deal with live table updates. SCH_LAB app can be restarted if the config table changes.
This was
linked to
issues
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate 20200304
Fixes #27, #31, and #32
See PR #33 for more details.
Testing performed
CI Testing only
Expected behavior changes
#27 - Improved table handling, see Issue
#31 - sch_lab now builds on Raspbian OS
#32 - Consolidate globals
System(s) tested on
Ubuntu
Additional context
See PR #33
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz NASA/GSFC