Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ICG compatible with clang/llvm 15 #1449 #1450

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Make ICG compatible with clang/llvm 15 #1449 #1450

merged 1 commit into from
Feb 7, 2023

Conversation

alexlin0
Copy link
Contributor

@alexlin0 alexlin0 commented Feb 2, 2023

Made a couple of changes in ICG source code to handle clang API differences. Encapsulated differences in ifdefs. Added libclangSupport to ICG link line.

@alexlin0
Make ICG compatible with clang/llvm 15 #1449
dd16076 
Made a couple of changes in ICG source code to handle clang API differences.  Encapsulated
differences in ifdefs.  Added libclangSupport to ICG link line.
@coveralls
Copy link

Coverage Status

Coverage: 56.366% (+0.07%) from 56.3% when pulling dd16076 on 1449-clang15 into afbc78c on master.

jmpenn
jmpenn reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@jmpenn jmpenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of comments regarding commented out code. Again, thanks!

@jmpenn jmpenn merged commit a48b39b into master Feb 7, 2023
@jmpenn jmpenn mentioned this pull request Feb 7, 2023
Closed
@jdeans289 jdeans289 deleted the 1449-clang15 branch June 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpenn jmpenn jmpenn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlin0 @coveralls @jmpenn