Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spacemacs-theme-use #89

Closed
wants to merge 1 commit into from

Conversation

jabranham
Copy link
Contributor

This fixes issue #78, and possibly #65

This is a pretty hackish way to do it, but it seems to work, at least for me. The code is kinda gross, though, so feel free to close this PR without merging if you want.

I can't figure out how the package name gets translated from spacemacs-common to spacemacs-theme, so I'm not sure how this will hold up once MELPA grabs it.

This fixes issue nashamri#78, and possibly nashamri#65
@nashamri
Copy link
Owner

Hey @jabranham thanks for this 😄

I appreciate your effort trying to fix this but I'm not really sure. I've tested sanityinc-solarized and solarized-emacs and both have the same issue. However, zenburn doens't have the issue but it's a single theme package without two variants as the case in spacemacs-theme.

And there's the issue of MELP packaging, if you go to spacemacs-theme on MELPA, you'll see that the commentary lines don't show up (related PR). And with this PR also depending on how MELPA will deal with the package, I think we should try running MELPA locally and test it out. I didn't try running MELPA locally before, so I don't know how hard that will be.

@jabranham
Copy link
Contributor Author

jabranham commented Oct 27, 2017 via email

@eflanigan00
Copy link

I tried this and unfortunately it didn't solve #65

@jabranham jabranham closed this Mar 21, 2018
@ninrod
Copy link

ninrod commented Mar 21, 2018

@jabranham: running melpa locally: https://github.com/ninrod/emacs-antiproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants