Convert included string-form tasks #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the tasks are in the dict-form before trying to assign a "cwd" to the definition.
2 tasks
nat-n
force-pushed
the
issue-158-include-in-lined-tasks
branch
from
b59abae
to
0665995
Compare
nat-n
approved these changes
Aug 5, 2023
|
Hi @rjaduthie, thanks for reporting this bug and proposing a fix. As you can see I amended your changes to add a failing test and a small refactor to enable a more comprehensive fix. The issue being that normally the default task type (for a task defined as a string) depends on the configured This fix will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the tasks are in the dict-form before trying to assign a "cwd" to the definition.
This is related to issue #158
Sorry no tests for it yet. I'll come back and add those, if you think this fix is worthwhile.