Source Snapchat Marketing: Add missing story metrics to basic stats (a…

…irbytehq#20897) * Add missing story metrics to basic stats * fix expected records and update dockerfile version * auto-bump connector version --------- Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
natalia-miinto · Jun 8, 2023 · cf60211 · cf60211
1 parent 32bdbdc
commit cf60211
Show file tree

Hide file tree

Showing 10 changed files with 114 additions and 98 deletions.
diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json b/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json
@@ -23938,7 +23938,7 @@
     "sourceDefinitionId": "200330b2-ea62-4d11-ac6d-cfe3e3f8ab2b",
     "name": "Snapchat Marketing",
     "dockerRepository": "airbyte/source-snapchat-marketing",
-    "dockerImageTag": "0.1.15",
+    "dockerImageTag": "0.1.16",
     "documentationUrl": "https://docs.airbyte.com/integrations/sources/snapchat-marketing",
     "icon": "snapchat.svg",
     "sourceType": "api",

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml
@@ -1951,7 +1951,7 @@
 - name: Snapchat Marketing
   sourceDefinitionId: 200330b2-ea62-4d11-ac6d-cfe3e3f8ab2b
   dockerRepository: airbyte/source-snapchat-marketing
-  dockerImageTag: 0.1.15
+  dockerImageTag: 0.1.16
   documentationUrl: https://docs.airbyte.com/integrations/sources/snapchat-marketing
   icon: snapchat.svg
   sourceType: api

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml
@@ -14601,7 +14601,7 @@
               path_in_connector_config:
               - "credentials"
               - "client_secret"
-- dockerImage: "airbyte/source-snapchat-marketing:0.1.15"
+- dockerImage: "airbyte/source-snapchat-marketing:0.1.16"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/snapchat-marketing"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-snapchat-marketing/Dockerfile b/airbyte-integrations/connectors/source-snapchat-marketing/Dockerfile
@@ -25,5 +25,5 @@ COPY source_snapchat_marketing ./source_snapchat_marketing
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.15
+LABEL io.airbyte.version=0.1.16
 LABEL io.airbyte.name=airbyte/source-snapchat-marketing
diff --git a/airbyte-integrations/connectors/source-snapchat-marketing/acceptance-test-config.yml b/airbyte-integrations/connectors/source-snapchat-marketing/acceptance-test-config.yml
@@ -5,46 +5,49 @@ test_strictness_level: high
 acceptance_tests:
   spec:
     tests:
-    - spec_path: "source_snapchat_marketing/spec.json"
+      - spec_path: "source_snapchat_marketing/spec.json"
   connection:
     tests:
-    - config_path: "secrets/config.json"
-      status: "succeed"
-    - config_path: "integration_tests/invalid_config.json"
-      status: "failed"
+      - config_path: "secrets/config.json"
+        status: "succeed"
+      - config_path: "integration_tests/invalid_config.json"
+        status: "failed"
   discovery:
     tests:
-    - config_path: "secrets/config.json"
+      - config_path: "secrets/config.json"
   basic_read:
     tests:
-    - config_path: "secrets/config.json"
-      expect_records:
-        path: "integration_tests/expected_records.jsonl"
-      empty_streams:
-      - name: "adaccounts_stats_lifetime"
-        bypass_reason: "The data changes from sync to sync"
-      - name: "ads_stats_lifetime"
-        bypass_reason: "The data changes from sync to sync"
-      - name: "adsquads_stats_lifetime"
-        bypass_reason: "The data changes from sync to sync"
-      - name: "campaigns_stats_lifetime"
-        bypass_reason: "The data changes from sync to sync"
-      fail_on_extra_columns: false
+      - config_path: "secrets/config.json"
+        expect_records:
+          path: "integration_tests/expected_records.jsonl"
+          extra_fields: no
+          exact_order: no
+          extra_records: yes
+        empty_streams:
+          - name: "adaccounts_stats_lifetime"
+            bypass_reason: "The data changes from sync to sync"
+          - name: "ads_stats_lifetime"
+            bypass_reason: "The data changes from sync to sync"
+          - name: "adsquads_stats_lifetime"
+            bypass_reason: "The data changes from sync to sync"
+          - name: "campaigns_stats_lifetime"
+            bypass_reason: "The data changes from sync to sync"
+        fail_on_extra_columns: false
   incremental:
     tests:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/incremental_catalog.json"
-      future_state:
-        future_state_path: "integration_tests/abnormal_state.json"
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/catalog_daily.json"
-      future_state:
-        future_state_path: "integration_tests/abnormal_state_daily.json"
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/incremental_catalog.json"
+        future_state:
+          future_state_path: "integration_tests/abnormal_state.json"
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/catalog_daily.json"
+        future_state:
+          future_state_path: "integration_tests/abnormal_state_daily.json"
   full_refresh:
     tests:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/configured_catalog.json"
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/catalog_lifetime.json"
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/catalog_daily.json"
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/configured_catalog.json"
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/catalog_lifetime.json"
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/catalog_daily.json"
diff --git a/...ntegrations/connectors/source-snapchat-marketing/integration_tests/expected_records.jsonl b/...ntegrations/connectors/source-snapchat-marketing/integration_tests/expected_records.jsonl
diff --git a/...s/connectors/source-snapchat-marketing/source_snapchat_marketing/schemas/basic_stats.json b/...s/connectors/source-snapchat-marketing/source_snapchat_marketing/schemas/basic_stats.json
@@ -221,6 +221,12 @@
     },
     "earned_reach": {
       "type": ["null", "number"]
+    },
+    "story_opens": {
+      "type": ["null", "number"]
+    },
+    "story_completes": {
+      "type": ["null", "number"]
     }
   }
 }
diff --git a/...yte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py b/...yte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py
@@ -86,6 +86,8 @@
     "custom_event_3",
     "custom_event_4",
     "custom_event_5",
+    "story_opens",
+    "story_completes",
 ]
 
 METRICS_NOT_HOURLY = [

diff --git a/connectors.md b/connectors.md
@@ -224,7 +224,7 @@
 | **Smaily** | <img alt="Smaily icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/smaily.svg" height="30" height="30"/> | Source | airbyte/source-smaily:0.1.0 | alpha | [docs](https://docs.airbyte.com/integrations/sources/smaily) | [connectors/source/smaily](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/smaily) | [source-smaily](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-smaily) | <small>`781f8b1d-4e20-4842-a2c3-cd9b119d65fa`</small> |
 | **SmartEngage** | <img alt="SmartEngage icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/smartengage.svg" height="30" height="30"/> | Source | airbyte/source-smartengage:0.1.0 | alpha | [docs](https://docs.airbyte.com/integrations/sources/smartengage) | [connectors/source/smartengage](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/smartengage) | [source-smartengage](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-smartengage) | <small>`21cc4a17-a011-4485-8a3e-e2341a91ab9f`</small> |
 | **Smartsheets** | <img alt="Smartsheets icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/smartsheet.svg" height="30" height="30"/> | Source | airbyte/source-smartsheets:1.0.0 | beta | [docs](https://docs.airbyte.com/integrations/sources/smartsheets) | [connectors/source/smartsheets](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/smartsheets) | [source-smartsheets](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-smartsheets) | <small>`374ebc65-6636-4ea0-925c-7d35999a8ffc`</small> |
-| **Snapchat Marketing** | <img alt="Snapchat Marketing icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/snapchat.svg" height="30" height="30"/> | Source | airbyte/source-snapchat-marketing:0.1.15 | generally_available | [docs](https://docs.airbyte.com/integrations/sources/snapchat-marketing) | [connectors/source/snapchat-marketing](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/snapchat-marketing) | [source-snapchat-marketing](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-snapchat-marketing) | <small>`200330b2-ea62-4d11-ac6d-cfe3e3f8ab2b`</small> |
+| **Snapchat Marketing** | <img alt="Snapchat Marketing icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/snapchat.svg" height="30" height="30"/> | Source | airbyte/source-snapchat-marketing:0.1.16 | generally_available | [docs](https://docs.airbyte.com/integrations/sources/snapchat-marketing) | [connectors/source/snapchat-marketing](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/snapchat-marketing) | [source-snapchat-marketing](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-snapchat-marketing) | <small>`200330b2-ea62-4d11-ac6d-cfe3e3f8ab2b`</small> |
 | **Snowflake** | <img alt="Snowflake icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/snowflake.svg" height="30" height="30"/> | Source | airbyte/source-snowflake:0.1.34 | alpha | [docs](https://docs.airbyte.com/integrations/sources/snowflake) | [connectors/source/snowflake](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/snowflake) | [source-snowflake](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-snowflake) | <small>`e2d65910-8c8b-40a1-ae7d-ee2416b2bfa2`</small> |
 | **Sonar Cloud** | <img alt="Sonar Cloud icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/sonarcloud.svg" height="30" height="30"/> | Source | airbyte/source-sonar-cloud:0.1.1 | alpha | [docs](https://docs.airbyte.com/integrations/sources/sonar-cloud) | [connectors/source/sonar-cloud](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/sonar-cloud) | [source-sonar-cloud](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-sonar-cloud) | <small>`3ab1d7d0-1577-4ab9-bcc4-1ff6a4c2c9f2`</small> |
 | **SpaceX API** | <img alt="SpaceX API icon" src="https://raw.githubusercontent.com/airbytehq/airbyte /master/airbyte-config-oss/init-oss/src/main/resources/icons/spacex.svg" height="30" height="30"/> | Source | airbyte/source-spacex-api:0.1.0 | alpha | [docs](https://docs.airbyte.com/integrations/sources/spacex-api) | [connectors/source/spacex-api](https://github.com/airbytehq/airbyte/issues?q=is:open+is:issue+label:connectors/source/spacex-api) | [source-spacex-api](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-spacex-api) | <small>`62235e65-af7a-4138-9130-0bda954eb6a8`</small> |

diff --git a/docs/integrations/sources/snapchat-marketing.md b/docs/integrations/sources/snapchat-marketing.md
@@ -113,6 +113,7 @@ Snapchat Marketing API has limitations to 1000 items per page.
 
 | Version | Date       | Pull Request                                             | Subject                                               |
 |:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------|
+| 0.1.16  | 2023-04-20 | [20897](https://github.com/airbytehq/airbyte/pull/20897) | Add missing fields to Basic Stats schema       |    
 | 0.1.15  | 2023-03-02 | [22869](https://github.com/airbytehq/airbyte/pull/22869) | Specified date formatting in specification                                                     |                                        
 | 0.1.14  | 2023-02-10 | [22808](https://github.com/airbytehq/airbyte/pull/22808) | Enable default `AvailabilityStrategy`                       |
 | 0.1.13  | 2023-01-27 | [22023](https://github.com/airbytehq/airbyte/pull/22023) | Set `AvailabilityStrategy` for streams explicitly to `None` |