Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setVideoMaxDuration() API #172

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Add setVideoMaxDuration() API #172

merged 2 commits into from
Mar 1, 2018

Conversation

natario1
Copy link
Owner

@natario1 natario1 commented Mar 1, 2018

Fixes #65 (it's the best we can do)

@codecov
Copy link

codecov bot commented Mar 1, 2018 •
edited
Loading

Codecov Report

Merging #172 into master will increase coverage by 0.3%.
The diff coverage is 50%.

Impacted Files Coverage Δ Complexity Δ
...ain/java/com/otaliastudios/cameraview/Camera2.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/com/otaliastudios/cameraview/Camera1.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...com/otaliastudios/cameraview/CameraController.java 28.1% <100%> (+1.9%) 27 <4> (+4) ⬆️
.../java/com/otaliastudios/cameraview/CameraView.java 68% <57.1%> (+0.8%) 110 <3> (+4) ⬆️

@natario1 natario1 merged commit c1973b0 into master Mar 1, 2018
@natario1 natario1 deleted the video-duration branch March 1, 2018 18:14
@Johnson145 Johnson145 mentioned this pull request Sep 28, 2018
Closed
2 tasks
@lancewoo lancewoo mentioned this pull request Dec 25, 2021
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natario1