Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setVideoMaxDuration() API #172

merged 2 commits into from Mar 1, 2018


Copy link

commented Mar 1, 2018

Fixes #65 (it's the best we can do)


This comment has been minimized.

Copy link

commented Mar 1, 2018

Codecov Report

Merging #172 into master will increase coverage by 0.3%.
The diff coverage is 50%.

Impacted Files Coverage Δ Complexity Δ
...ain/java/com/otaliastudios/cameraview/ 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/com/otaliastudios/cameraview/ 0% <0%> (ø) 0 <0> (ø) ⬇️ 28.1% <100%> (+1.9%) 27 <4> (+4) ⬆️
.../java/com/otaliastudios/cameraview/ 68% <57.1%> (+0.8%) 110 <3> (+4) ⬆️

@natario1 natario1 merged commit c1973b0 into master Mar 1, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 70%)
codecov/project 54.9% (target 50%)
continuous-integration/travis-ci/pr The Travis CI build passed

@natario1 natario1 deleted the video-duration branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.