-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix when it is not buffer.hasRemaining(refs #144 #153) #158
Conversation
@natario1 |
I also need this fix please and thank you @jumperson. |
Thanks! I would prefer if we understand why buffer is empty. Where is it coming from? Seems like a bug upstream (either in Transcoder code, or in device decoders) that we should fix. Also with the proposed solution the buffer is never released. |
when using com.otaliastudios:transcoder:0.10.4", I have same issue. java.lang.IllegalArgumentException: bufferInfo must specify a valid buffer offset, size and presentation time LiTr had same issue and it was fixed.
|
@jumperson, @natario1 this fixes the issue for me, specifically any videos recorded on iOS seems to have this issue (using this fork https://github.com/StudistCorporation/Transcoder) |
@natario1 is there anything I can help with so that this would get merged and a new version would be published? |
As I said before, ideally we should understand where this buffer is coming from, it seems like we are patching a bug that is somewhere upstream in the pipeline. But if no one has time to do so, at least the buffer should be released in an else branch, otherwise it's leaked (I think). I can merge the PR after this, and could also use some help with publishing a new version. |
Looks like sonatype is down now https://status.maven.org/incidents/pplp3ln3vs81 - when they fix it you'll be able to use the snapshot version. For a real release I would appreciate if someone made a simple version bump PR like this, listing the fixes since previous version. |
There was a case where
buffer.isremining()
was false when used withAudioEngine
.When I debugged, the capacity of buffer was 0.
refs: #144 #153