Fix Xamarin Incompatibility #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to bother, but can you make the overrides protected instead? It makes much more sense. Thanks for spotting this |
|
No problem at all, I can definitely do that. Thanks for taking a look! |
|
Sorry, I need to clean up this commit history. Working on it. |
When I try to convert the library to Xamarin, I have a small issue with access modifiers. I think C# is a little more strict than java on this, but the issue is that if an abstract method is protected, an override must be protected or private. It can't be made public. In the Transcoder library, DefaultDataSource.applyExtractor and DefaultDataSource.applyRetriever are protected, but all the overrides are public. This PR makes the subclass methods protected to remove the issue.
|
Alright, all fixed up. Updated these files and the commit message. |
natario1
approved these changes
Oct 25, 2019
|
Thank you @aweck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Xamarin Incompatibility
When I try to convert the library to Xamarin, I have a small issue with access modifiers. I think C# is a little more strict than java on this, but the issue is that if an abstract method is protected, an override must be protected or private. It can't be made public. In the Transcoder library, DefaultDataSource.applyExtractor and DefaultDataSource.applyRetriever are protected, but all the overrides are public. This PR makes the base class abstract methods public to remove the issue.