Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Makefile to point to new git home. #37 #38

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

phargogh
Copy link
Member

This PR updates the Makefile to use the new git home of the user's guide.

@phargogh phargogh self-assigned this Feb 26, 2020
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though Github is showing an Unchanged files with check annotations section with the ui_tests/test_ui_inputs.py file displaying check failures. This is under the Files changed tab. Doesn't seem like these things are related?

@phargogh
Copy link
Member Author

@dcdenu4 yeah, I've been seeing those annotations as well. From what I can tell, I think GitHub is picking up on the fact that the UI tests include some where an exception is being printed to the logfile as a part of the run (which is an expected part of the test itself). The tests that are logging these exceptions are behaving as expected, so I think we can safely ignore them.

Come to think of it, it might be a better choice to only include the logging when there's a test failure and not print out everything! That would prevent github actions from annotating a false positive.

@dcdenu4 dcdenu4 self-requested a review February 27, 2020 18:32
@dcdenu4 dcdenu4 merged commit 0452221 into natcap:master Feb 27, 2020
@phargogh phargogh deleted the bugfix/update-invest-ug-github branch February 27, 2020 18:34
emlys added a commit to emlys/invest that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants