Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workspace folders #383

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Commits on Jan 21, 2021

  1. Experiment with workspaceFolders

    - Pass the file path of the buffer which triggered the server to start
      to decide the first workspace root. In the case of a server restart,
      remember the file that was open when the restart command was issued.
    - Add a `lsc#workspace#findMarker` utility function to search upwards
      from a file to a directory which contains some other file that marks
      the "root" for that project.
    
    TODO:
    - Add docs.
    - Check capabilities before sending the message.
    - Figure out if removing roots is necessary. This would require tracking
      per-server lists of files.
    - Allow giving a name to the roots.
    - Implement the `workspace/workspaceFolders` request.
    
    Potential future support
    - A known file like `.lsc_root` to reliably locally mark the root for
      any given workspace.
    - Support for user specific project roots, or perhaps just support the
      common ones from the start, like `.git/`
    natebosch committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    37f6517 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2021

  1. Start hacking together a test

    - Add a stub for `lsc#workspace#byMarker()` to make it easier to write
      the tests.
    - Read client capabilities in `StubServer`.
    - Outline some tests. Add a test reading client capabilities.
    natebosch committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    d4b7435 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1027818 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea701cd View commit details
    Browse the repository at this point in the history
  4. More tests passing

    natebosch committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    a6efb87 View commit details
    Browse the repository at this point in the history
  5. Get existing tests passing

    natebosch committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    a56c349 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a9eadd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b5e36b9 View commit details
    Browse the repository at this point in the history
  8. Fix the test

    Report stderr for vim.expr (might be helpful in other places too). Fix
    the bug surfaced by this output with an extra closing paren.
    
    Send an extra "<cr>" since the multiple sendKeys seem to leave vim in a
    state with a "Press Enter to continue", maybe where it prints the
    function that was just created?
    natebosch committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    8587c83 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    14e7f71 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    917ccab View commit details
    Browse the repository at this point in the history
  11. Potentially friendlier name

    natebosch committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    e612766 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Configuration menu
    Copy the full SHA
    a1fe031 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Configuration menu
    Copy the full SHA
    3de130d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Configuration menu
    Copy the full SHA
    7b877e1 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Configuration menu
    Copy the full SHA
    227a22c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Configuration menu
    Copy the full SHA
    c9eb6a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Another trailing slash

    natebosch committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    4122cd3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcef1fd View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Configuration menu
    Copy the full SHA
    b072c6a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Configuration menu
    Copy the full SHA
    0d4dae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Drop trailing slashes

    natebosch committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    fbcce1c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Configuration menu
    Copy the full SHA
    fcc8822 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Configuration menu
    Copy the full SHA
    5fa9822 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Configuration menu
    Copy the full SHA
    c67ff23 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Configuration menu
    Copy the full SHA
    235f569 View commit details
    Browse the repository at this point in the history