Make default log file mode 0600 #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file is not pre-created, the default mode were 0644. This could be very problematic for audit log files which require tighter permissions. This changes the default mode to be 0600 which is more restrictive. Note that rotation of log files already uses this mode by default. Also note that when files are pre-created, the mode the file already had is respected.
|
Here's the thing, we already set the default log mode to 600 when opening a new log file. That line you changed only opens an existing log file. The filemod in that call is ignored when opening an existing file. You can see that here: https://play.golang.org/p/cupAhV1GAI1 It might be worth a comment saying "hey, this filemod gets ignored" and maybe setting it to 0000 just to show it's really and truly not a valid value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file is not pre-created, the default mode were 0644. This
could be very problematic for audit log files which require tighter
permissions.
This changes the default mode to be 0600 which is more
restrictive. Note that rotation of log files already uses this
mode by default. Also note that when files are pre-created, the mode the
file already had is respected.