Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double help #10

Merged
merged 1 commit into from
Jun 28, 2013
Merged

Avoid double help #10

merged 1 commit into from
Jun 28, 2013

Conversation

felds
Copy link
Contributor

@felds felds commented May 7, 2013

This assures the parse method is called only once.

When the script is short-circuited on default help, it exists without mark the command as parsed, showing the helo message twice.

All tests passed.

@unstoppablecarl
Copy link
Contributor

I get the double help bug with the following code

$cmd = new Commando\Command();

$cmd->option('p')
    ->require()
    ->aka('package')
    ->describedAs('The name of the package dir');

$cmd->option('c')
    ->require()
    ->aka('class')
    ->describedAs('The full namespaced class name of the model, will be added to -namespace if set');

$cmd->option('ns')
    ->aka('namespace')
    ->describedAs('The namespace of the package module');

This pull request fixes that why hasn't this been merged?

@felds
Copy link
Contributor Author

felds commented Jun 19, 2013

are you there, @nategood ?

@unstoppablecarl
Copy link
Contributor

It is so frustrating when this happens. This is a nice package but has a small bug.

@nategood
Copy link
Owner

Sorry guys. Had a bit of a health scare recently that has set me behind on my inbox. I'll review and merge.

nategood added a commit that referenced this pull request Jun 28, 2013
@nategood nategood merged commit 7b65aa7 into nategood:master Jun 28, 2013
@felds
Copy link
Contributor Author

felds commented Jul 1, 2013

@nategood no worries, man! thank you!
btw, are you better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants