Dev

[phil043]

Hi,

After a false start I've uploaded a version that enables --option=value style arguments. This is a fairly widely used method of passing in automatically generated arguments to a script (in our case our system uses it extensively).

It also adds a couple of tests for it.

There's a bug in the current dev branch Option::hasNeeds method that I've fixed - the in_array call wasn't using strict and was crashing on my tests as it was passing everything. This is happening because for whatever reason there's always an integer 0 in the "$definedOptions" array that is used in the method to check which options have been passed in allowing it to always return true.

The offending code is the first line in the below block:

if (!in_array($need, $definedOptions)) { <---- contains a 0 so matches any string in $need
                // The needed option has not been defined as a valid flag.
                $notFound[] = $need;
            } elseif (!$optionsList[$need]->getValue()) {
                // The needed option has been defined as a valid flag, but was
                // not pased in by the user.
                $notFound[] = $need;
            }

The first line should be (and in my version has been changed to be):

if (!in_array($need, $definedOptions, true)) {

There should probably be a proper method for it which loops through the array and does a proper comparison..

Finally I made a few small readability improvements in the Command::parse() method as it was getting confusing.

[Potherca]

This PR has some minor syntax issues in regards to NULL and FALSE not being lowercase and some method braces being moved onto the same line as the method declaration (basically not being PSR-2 compliant) but other than that, can we please haz this @nategood? 😺

[NeoVance]

I am not a fan of the --flag=value syntax because it does not feel like a native command, so I don't feel any urgent need to include this as a feature.

[NeoVance]

If you move the regex group for the = outside of the name group, you would not need this str_replace, and you most likely do not need the extra identifier OPTION_TYPE_VERBOSE_EQUALS so it would be treated like any other long or short option.

[NeoVance]

Args don't have to have a value. Boolean flags are either off or on, and don't need to be supplied a value generally. If you are using an = on all of your options to denote a value than of course that will change the assumption that the next token must be a value for this option rather than another flag.