-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1] chore: cleaning up typings and organization #99
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -140,6 +140,10 @@ import { Icon } from 'astro-icon/components'; | |||
<Icon name="annotation" /> <!-- will be red --> | |||
``` | |||
|
|||
### Using with Frameworks | |||
|
|||
Astro Icon can be used with other frameworks utilizing the [`slot` element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/slot). You can read more about how to use Slots in Astro here. [Passing Children to Framework Components](https://docs.astro.build/en/core-concepts/framework-components/#passing-children-to-framework-components) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f7e458e
to
f68f8c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Great stuff, thank you!
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Working to resolve outstanding typing issues and re-organizing a bit.
Documents slot usage - #41