[v1] chore: cleaning up typings and organization #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stramel
changed the title
stramel
commented
May 24, 2023
| @@ -140,6 +140,10 @@ import { Icon } from 'astro-icon/components'; | |||
| <Icon name="annotation" /> <!-- will be red --> | |||
| ``` | |||
|
|
|||
| ### Using with Frameworks | |||
|
|
|||
| Astro Icon can be used with other frameworks utilizing the [`slot` element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/slot). You can read more about how to use Slots in Astro here. [Passing Children to Framework Components](https://docs.astro.build/en/core-concepts/framework-components/#passing-children-to-framework-components) | |||
There was a problem hiding this comment.
stramel
changed the title
natemoo-re
force-pushed
the
ms/document-v1
branch
2 times, most recently
from
f7e458e
to
f68f8c3
Compare
natemoo-re
pushed a commit
that referenced
this pull request
Jun 6, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re
pushed a commit
that referenced
this pull request
Dec 21, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re
pushed a commit
that referenced
this pull request
Dec 22, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re
pushed a commit
that referenced
this pull request
Dec 22, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re
pushed a commit
that referenced
this pull request
Dec 22, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re
pushed a commit
that referenced
this pull request
Dec 22, 2023
* chore: convert core package to typescript * feat: remove Iconify requirement * docs: update core README * chore: update website to use latest code * fix: improve typings and organization * fix: generating icon type definitions * chore(lint): Prettier fix * fix readme --------- Co-authored-by: Michael Stramel <michael.stramel@koyfin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working to resolve outstanding typing issues and re-organizing a bit.
Documents slot usage - #41