New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI breakage caused by snowpack 3.0.0 API updates #90
Fix CLI breakage caused by snowpack 3.0.0 API updates #90
Conversation
This compensates for Snowpack renaming its `startDevServer` API to `startServer`. This API was renamed as part of the official 3.0 release, breaking projects, including microsite, that were using the release candidate.
…gnatureof snowpack’s `createConfiguration` API Fixes #87
|
This pull request is being automatically deployed with Vercel (learn more). microsite-examples – ./🔍 Inspect: https://vercel.com/nmoo/microsite-examples/q3epm499f microsite – ./site🔍 Inspect: https://vercel.com/nmoo/microsite/awwlfznje |
Thanks so much! I've made the same changes and am hoping to get I don't think I'll be able to add these fixes into Microsite@1.0.x because |
Going to close this in favor of #94. I implemented all of these changes, but there were even more that I had to figure out specific to Microsite's internals. Notably:
|
Snowpack’s public JavaScript API changed somewhat between the 3.0 release candidates and the 3.0 official release. Because microsite’s version range for snowpack is
^3.0.0-rc.2
, snowpack currently resolves to3.0.10
—thus breaking the microsite CLI.Changes to Snowpack’s JavaScript API that affect microsite:
buildProject
tobuild
startDevServer
tostartServer
createConfiguration
This PR smooths over those upstream API changes, as well as changes the accepted range for snowpack to
^3.0.0
.Closes #87.