Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI breakage caused by snowpack 3.0.0 API updates #90

Closed
wants to merge 4 commits into from
Closed

Fix CLI breakage caused by snowpack 3.0.0 API updates #90

wants to merge 4 commits into from

Conversation

tylerbrostrom
Copy link

Snowpack’s public JavaScript API changed somewhat between the 3.0 release candidates and the 3.0 official release. Because microsite’s version range for snowpack is ^3.0.0-rc.2, snowpack currently resolves to 3.0.10—thus breaking the microsite CLI.

Changes to Snowpack’s JavaScript API that affect microsite:

  • renaming buildProject to build
  • renaming startDevServer to startServer
  • changing the return signature of createConfiguration

This PR smooths over those upstream API changes, as well as changes the accepted range for snowpack to ^3.0.0.

Closes #87.

This compensates for Snowpack renaming its `startDevServer` API to `startServer`. This API was renamed as part of the official 3.0 release, breaking projects, including microsite, that were using the release candidate.
…gnatureof snowpack’s `createConfiguration` API

Fixes #87
@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2021

⚠️ No Changeset found

Latest commit: 0ed7e6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@example/*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

microsite-examples – ./

🔍 Inspect: https://vercel.com/nmoo/microsite-examples/q3epm499f
✅ Preview: Failed

microsite – ./site

🔍 Inspect: https://vercel.com/nmoo/microsite/awwlfznje
✅ Preview: Canceled

@natemoo-re
Copy link
Owner

Thanks so much! I've made the same changes and am hoping to get v1.1.0 (using Snowpack's new 3.0.0 API) out the door in the next day or two.

I don't think I'll be able to add these fixes into Microsite@1.0.x because main is already on next. That's my fault and I'll need to find a better branching strategy moving forward.

@natemoo-re
Copy link
Owner

Going to close this in favor of #94. I implemented all of these changes, but there were even more that I had to figure out specific to Microsite's internals.

Notably:

  • The structure of snowpack.config.js changed
  • The default build output changed from __snowpack__ and web_modules to _snowpack and _snowpack/pkg

@natemoo-re natemoo-re closed this Jan 20, 2021
@natemoo-re natemoo-re mentioned this pull request Jan 20, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to run project
2 participants