ie7

[ifremen]

Hi, thanks so much for this great tool!

Unfortunately I have to support clients on ie7 but it doesn't appear to be working for me in ie7. I notice in CropImage.cs line 282 appends a comma at the end of the value appended to the stringbuilder. ie7 doesn't like a final comma at the end of the last item. However, even when I remove the last comma and build the solution, ie7 crashes when I try to define a crop area so I'm not sure how to fix.

btw I used the basic.aspx page as an example.

Thanks :)

[lilith]

The process dies? Or is there an error message?

[ifremen]

Before fixing the "last comma" issue (just running the Basic.aspx example) the browser has the following javascript error:

SCRIPT1028: Expected identifier, string or number

Basic.aspx, line 27 character 1

When clicking on this error in the console it shows the line after that last comma. The jsvascript stops processing, of course, after this error so the screen looks like the attachment att1_cropimage_ie7_js_error.jpg.

After doing a quick fix to the code in CropImage.cs that doesn't write the last comma, yes IE7 just dies. See attachment att2_cropimage_ie7_js_error.jpg with the webcropimage code highlighted in the console. Please not also that the page runs fine at first (no javascript error when the page load). The browser dies after I click the crop button and try to define an area in the pic on top.

If you run your Basic example in IE7 you can see the first issue.

---

From: "Nathanael Jones" notifications@github.com
Sent: Sunday, May 12, 2013 9:57 AM
To: "nathanaeljones/cropimage" cropimage@noreply.github.com
Subject: Re: [cropimage] ie7 (#2)

The process dies? Or is there an error message?

Reply to this email directly or view it on GitHub.

[ifremen]

A co-worker tested the original version you refer to below and the same ie7 issue is happening. I will find another tool. thx.

---

From: "Cem Sisman" notifications@github.com
Sent: Sunday, May 12, 2013 6:31 AM
To: "nathanaeljones/cropimage" cropimage@noreply.github.com
Subject: Re: [cropimage] ie7 (#2)

I would recommend using the original version of crop image control, it has been updated recently.

Reply to this email directly or view it on GitHub.

[lilith]

Does this happen with the JCrop example as well? This control uses jCrop as-is.

http://deepliquid.com/projects/Jcrop/demos.php

[ifremen]

hmm after seeing it not working on my IE10 in IE7 and on IE9 in IE7 mode, I accessed a remote server with true ie7 and it seems to work there.

I'll re-upload my code to a server and test in true IE7 to see if it works. (I probably won't be able to do this until tomorrow but I will keep you posted).

Thanks so much for you persistence and help :)

-Tamara

---

From: "Nathanael Jones" notifications@github.com
Sent: Monday, May 13, 2013 11:41 AM
To: "nathanaeljones/cropimage" cropimage@noreply.github.com
Subject: Re: [cropimage] ie7 (#2)

Does this happen with the JCrop example as well? This control uses jCrop as-is.

http://deepliquid.com/projects/Jcrop/demos.php

Reply to this email directly or view it on GitHub.