Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of function GetVendor #2

Closed
NathanGibbs3 opened this issue Feb 25, 2019 · 0 comments
Closed

Return value of function GetVendor #2

NathanGibbs3 opened this issue Feb 25, 2019 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

File: base_common.php
function GetVendor
Expected Behavior: return Vendor Name.
Current Behavior:
Returns the Vendor Name prefixed by a space character.
Found via new PHPUnit test.
Which is why testing is important.
Although this issue does not effect the usability of the software, it is a bug.
@NathanGibbs3 NathanGibbs3 added bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right labels Feb 25, 2019
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190111 Mysql fix. #2
fc5857e
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190111 Build fix. #2
535c597
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190111 Code Coverage #2
5d6e8c9
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190212 Code Coverage #2
cd90596
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190213 Build fix #4
c9353f7 
20190213 Code Coverage #2
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190214 Build fix #2
4475a9d
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190215 Build fix #2
83e988d
NathanGibbs3 added a commit that referenced this issue Mar 7, 2019
@NathanGibbs3
20190307 Bug-Fix Closes #2
1a5f528 
Code Coverage 1
PHP Version check fix
Changed .gitignore to ignore Composer noise.
@NathanGibbs3 NathanGibbs3 mentioned this issue Mar 8, 2019
Closed
@NathanGibbs3 NathanGibbs3 added the LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. label Mar 11, 2019
@NathanGibbs3 NathanGibbs3 self-assigned this Mar 15, 2019
@NathanGibbs3 NathanGibbs3 removed the good first issue Good for newcomers label Mar 15, 2019
@NathanGibbs3 NathanGibbs3 added the Prod Observed in Production Environment. label May 14, 2019
@NathanGibbs3 NathanGibbs3 added the UI User Interface Issues. label May 15, 2020
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Sep 13, 2020
NathanGibbs3 added a commit that referenced this issue May 5, 2023
@NathanGibbs3
20230504 Fix CI build breakage. #2
06840cc
NathanGibbs3 added a commit that referenced this issue May 5, 2023
@NathanGibbs3
20230505 Closes #98 Closes #158
2148eb9 
         Fix CI build breakage. #2
NathanGibbs3 added a commit that referenced this issue May 11, 2023
@NathanGibbs3
2023-05-11 Fix CI build breakage. #2
5693846
NathanGibbs3 added a commit that referenced this issue May 12, 2023
@NathanGibbs3
20230511 Closes #198 CI build Production Test. #2
4af4ba2 
     File(s): includes/base_rtl.php
              Bumped RTL Version to 0.0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3