Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit Tests for Postgresql flag as risky. #158

Closed
NathanGibbs3 opened this issue Mar 28, 2023 · 0 comments
Closed

PHPUnit Tests for Postgresql flag as risky. #158

NathanGibbs3 opened this issue Mar 28, 2023 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability. Tests Test Code & Config Issues. Local or CI Environments.

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented Mar 28, 2023 •
edited

Item Description
Link to example:
Build Environment: Travis-CI
PHP Version: 5.3 - 5.6 & 7.2
PHPUnit Version: 4.8x 5.7.x 6.4x
ADOBD Version: 5.10 - 5.21.4
Similar Issues: #98
Depends on Issue(s):
Dependency Type:
Misc Info: This is a PHPUnit Issue. PHPUnit < 6x manifest this bug on ADOdb < 5.22.0. Newer PHPUnits test ADOdb 5.20.0+ OK.

Expected Behavior: Tests run without being flagged as risky.
Current Behavior: Tests flag as risky.
Solution:

  • Upgrade the ADOdb version on builds using PHPUnit < 6x. NOT viable.
  • Disable backupGlobals function before the test that triggers this. Chosen Solution.
  • Upgrade to PHPUnit 6x+ on builds when possible. PHP7x+
@NathanGibbs3 NathanGibbs3 added the Tests Test Code & Config Issues. Local or CI Environments. label Mar 28, 2023
@NathanGibbs3 NathanGibbs3 self-assigned this Mar 28, 2023
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. DB Database Issues Stability Issue impacts or is related to App Stability. labels Mar 28, 2023
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Mar 28, 2023
@NathanGibbs3 NathanGibbs3 changed the title PHPUnit Tests for Postgresql flag as risky PHP 5.x - PHPUnit Tests for Postgresql flag as risky Mar 28, 2023
NathanGibbs3 added a commit that referenced this issue Mar 28, 2023
@NathanGibbs3
20230328 Fix CI build breakage.
9529126 
         Related Issue(s) #152 #155 #155 #158 #159 #160 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230328 Fix CI build breakage. 3
1dc2a76 
         Related Issue(s) #154 #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage.
0013a9c 
         Related Issue(s) #154 #155 #158 #159 #162
@NathanGibbs3 NathanGibbs3 changed the title PHP 5.x - PHPUnit Tests for Postgresql flag as risky PHPUnit Tests for Postgresql flag as risky Mar 29, 2023
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 2
37e013c 
         Related Issue(s) #154 #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 3
158f961 
         Related Issue(s) #154 #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 4
1a01456 
         Related Issue(s) #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 5
04fe32a 
         Related Issue(s) #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 6
e9b8125 
         Related Issue(s) #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 7
202ce7e 
         Related Issue(s) #155 #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 29, 2023
@NathanGibbs3
20230329 Fix CI build breakage. 8
c903093 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 31, 2023
@NathanGibbs3
20230331 Fix CI build breakage.
b2fd1f9 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 31, 2023
@NathanGibbs3
20230331 Fix CI build breakage. 2
d15e6f6 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Mar 31, 2023
@NathanGibbs3
20230331 Fix CI build breakage. 3
7c046b0 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230331 Fix CI build breakage. 4
68dc54c 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230401 Fix CI build breakage.
14fc1cf 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230401 Fix CI build breakage. 2
394b128 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230401 Fix CI build breakage. 3
d6ebc91 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230401 Fix CI build breakage. 4
9a956df 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 1, 2023
@NathanGibbs3
20230401 Fix CI build breakage. 5
0691b86 
         Related Issue(s) #158 #159 #162
NathanGibbs3 added a commit that referenced this issue Apr 2, 2023
@NathanGibbs3
20230401 Fix CI build breakage. 6
069ca68 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 2, 2023
@NathanGibbs3
20230402 Fix CI build breakage.
4daad54 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 2, 2023
@NathanGibbs3
20230402 Fix CI build breakage. 2
fe9f050 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 2, 2023
@NathanGibbs3
20230402 Fix CI build breakage. 3
004ecbf 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 2, 2023
@NathanGibbs3
20230402 Fix CI build breakage. 4
b40ccb4 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 3, 2023
@NathanGibbs3
20230402 Fix CI build breakage. 5
7650581 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 3, 2023
@NathanGibbs3
20230403 Fix CI build breakage.
0685ca1 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 3, 2023
@NathanGibbs3
20230403 Fix CI build breakage. 2
c517586 
         Related Issue(s) #158 #159 #162 #163
NathanGibbs3 added a commit that referenced this issue Apr 3, 2023
@NathanGibbs3
20230403 Fix CI build breakage. 3
d58d0c7 
         Related Issue(s) #158 #159 #163
NathanGibbs3 added a commit that referenced this issue Apr 3, 2023
@NathanGibbs3
20230403 Fix CI build breakage. 4
5b765b3 
         Related Issue(s) #158 #163
@NathanGibbs3 NathanGibbs3 removed this from the 1.4.6 milestone Apr 5, 2023
NathanGibbs3 added a commit that referenced this issue Apr 12, 2023
@NathanGibbs3
20230412 Fix CI build breakage.
944a38c 
         Related Issue(s) #158
@NathanGibbs3 NathanGibbs3 mentioned this issue Apr 13, 2023
Closed
@NathanGibbs3 NathanGibbs3 changed the title PHPUnit Tests for Postgresql flag as risky PHPUnit Tests for Postgresql flag as risky. May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability. Tests Test Code & Config Issues. Local or CI Environments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NathanGibbs3