Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 5.2x on Travis-CI - Test run & Code coverage generation Issues. #5

Open
NathanGibbs3 opened this issue Mar 7, 2019 · 5 comments
Open

PHP 5.2x on Travis-CI - Test run & Code coverage generation Issues. #5

NathanGibbs3 opened this issue Mar 7, 2019 · 5 comments
Assignees
@NathanGibbs3
Labels
invalid This doesn't seem right New-TechDebt Issue caused by previous commit to this repo. We created it. Tests Test Code & Config Issues. Local or CI Environments.

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented Mar 7, 2019 •
edited

Item Description
Related Issues:
Depends on Issue(s): #54 #10
Dependency Type: Hard

Link to example:
https://travis-ci.com/NathanGibbs3/BASE/jobs/183155000
Other Info:
Travis-CI
PHP 5.2.17
PHPUnit 3.6.12
XDebug enabled via file in Repo: https://github.com/NathanGibbs3/BASE/blob/devel/tests/5.2-xdebug.ini
To Understand how XDebug is enabled, see code in: https://github.com/NathanGibbs3/BASE/blob/devel/tests/setupenv.sh
Expected Behavior:
Code Coverage Reports are generated & tests run without warnings.
Current Behavior:
After successfully running Unit tests, PHPUnit prints:
Generating code coverage report in Clover XML format ...
Followed by a bunch of Warning & Notice Errors about the code such as:
Warning: include(../base_conf.php): failed to open stream: No such file or directory in /home/travis/build/NathanGibbs3/BASE/admin/base_roleadmin.php on line 21
Warning: include(): Failed opening '../base_conf.php' for inclusion (include_path='.:/home/travis/.phpenv/versions/5.2.17/pear') in /home/travis/build/NathanGibbs3/BASE/admin/base_roleadmin.php on line 21
Notice: Undefined variable: BASE_path in /home/travis/build/NathanGibbs3/BASE/admin/base_roleadmin.php on line 22
Notice: Use of undefined constant _SOURCE - assumed '_SOURCE' in /home/travis/build/NathanGibbs3/BASE/includes/base_state_citems.inc.php on line 953
etc.
Code Coverage Reports are not generated.
Solution:
I suspect this is a PHP 5.2 related Issue.
As I've already run into other issues with the PHP 5.2 Build environment on Travis-CI.
@NathanGibbs3 NathanGibbs3 added Tests Test Code & Config Issues. Local or CI Environments. invalid This doesn't seem right labels Mar 7, 2019
NathanGibbs3 added a commit that referenced this issue Mar 13, 2019
@NathanGibbs3
20190312 Issue #5 Fix Attempt 1
0985268
NathanGibbs3 added a commit that referenced this issue Mar 13, 2019
@NathanGibbs3
20190312 Issue #5 Fix Attempt 2
ad3ddf5
NathanGibbs3 added a commit that referenced this issue Mar 13, 2019
@NathanGibbs3
20190312 Issue #5 Fix Attempt 3
49a7f4c
NathanGibbs3 added a commit that referenced this issue Mar 13, 2019
@NathanGibbs3
20190312 Issue #5 Fix Attempt 4
01a85c8
NathanGibbs3 added a commit that referenced this issue Mar 13, 2019
@NathanGibbs3
20190312 Issue #5 Fix Attempt 5
f333b88
@NathanGibbs3
Copy link
Owner Author

Added a basic base_conf.php file in commit 49a7f4c
Got the file copy location fixed in commit f333b88
Not sure what the issue could be, as it's still not working.
https://travis-ci.com/NathanGibbs3/BASE/jobs/184396606

NathanGibbs3 added a commit that referenced this issue Mar 14, 2019
@NathanGibbs3
20190314 Closes #5
8d7114f 
Removed PHP 5.2 from CI Config.
CI builds for 5.2 started failing in devel yesterday.
Likely related to: https://blog.travis-ci.com/2017-04-17-precise-EOL
At some point, we will go through the same thing with PHP 5.3.
@NathanGibbs3 NathanGibbs3 self-assigned this Mar 15, 2019
@NathanGibbs3
Copy link
Owner Author

May be related to SSL support under PHP5.2x. More specifically the apparent lack thereof.
See: https://travis-ci.com/NathanGibbs3/BASE/jobs/197045705

NathanGibbs3 added a commit that referenced this issue May 14, 2019
@NathanGibbs3
20190111 Build fix. #5
8e6fa96
NathanGibbs3 added a commit that referenced this issue May 14, 2019
@NathanGibbs3
20190111 Code Coverage #5
301da32
NathanGibbs3 added a commit that referenced this issue May 14, 2019
@NathanGibbs3
20190214 Build fix #5
349546a
NathanGibbs3 added a commit that referenced this issue Jun 7, 2019
@NathanGibbs3
20190606 Enable PHP 5.2x in CI.
fb62f6d 
         So that we can test PHP Safe Mode code paths.
         Reopens Issue #5
@NathanGibbs3 NathanGibbs3 reopened this Jun 7, 2019
@NathanGibbs3 NathanGibbs3 changed the title Code Coverage Generation Issues Travis-CI PHP 5.2 PHP 5.2x on Travis-CI - Test run & Code coverage generation Issues. Jun 7, 2019
@NathanGibbs3
Copy link
Owner Author

NathanGibbs3 commented Jun 7, 2019 •
edited

Current sub Issues.

  • Package Installation.
    As PHP5.2 on travis-ci has no SSL support package installation broke when pear.php.net started using HTTPS by default.
    Solution: Manually script Package installation.
  • Test Run.
    Believe this is related to PHPUnit 3x. Need to research further.
  • Code Coverage.
    Related to XDebug extension not being enabled.
    Solution: Add custom config to Repo. and script it's installation into the environment.

NathanGibbs3 added a commit that referenced this issue Jun 7, 2019
@NathanGibbs3
20190606 Issue #5 Work 1
ec5f91a 
         Added $BASE_path initialization to files in admin.
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190606 Issue #5 Work 2
88cc6b5 
         Modified PHP 5.2 custom base_conf.
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190606 Issue #5 Work 3
906cffd 
         Add/Test/Use Non Assuming Constant set routine.
         SetConst()
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190606 Issue #5 Work 4
1772afc 
         All include(s) for includes/base_constants.inc.php
         Are now include_once()
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190606 Issue #5 Work 5
168b71f 
         All include(s) for includes/base_state_common.inc.php
         Are now include_once()
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190608 Issue #5 Work 1 Code Coverage.
a6b928d
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190608 Issue #5 Work 2
8be9faa 
         Conditional header exec.
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190608 Issue #5 Work 3 PHP 7x fix 1
e3e026d
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
20190608 Issue #5 Work 4 PHP 7x fix 2
23c252a
NathanGibbs3 added a commit that referenced this issue Jun 8, 2019
@NathanGibbs3
Revert "20190608 Issue #5 Work 3 PHP 7x fix 1"
b622c0e 
This reverts commit e3e026d.
NathanGibbs3 added a commit that referenced this issue Jun 9, 2019
@NathanGibbs3
20190608 Issue #5 Work 5
9a9f3f1 
         PHP 5.2x Unit Tests fix 1
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 5
bf361c5
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 6
2f4ee58
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 7
fe36d9a
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 8
b41de59
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 9
17e3534
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 10
833c026
NathanGibbs3 added a commit that referenced this issue Jun 21, 2019
@NathanGibbs3
20190621 Issue #5 Work 11
580f6e5
NathanGibbs3 added a commit that referenced this issue Jun 22, 2019
@NathanGibbs3
20190621 Issue #5 Work 12
c9489c5
@NathanGibbs3
Copy link
Owner Author

We've stopped chasing Issue #5 for now as we've hit a dead end in figuring out why it won't generate code coverage info in the default configuration.
Set these builds to use a custom phpunit config file with addUncoveredFilesFromWhitelist=false for now.

NathanGibbs3 added a commit that referenced this issue Jun 22, 2019
@NathanGibbs3
20190622 Issue #5 Work 1
0cfa12e
NathanGibbs3 added a commit that referenced this issue Jun 22, 2019
@NathanGibbs3
20190622 Issue #5 Work 2
a6069df
NathanGibbs3 added a commit that referenced this issue Jun 22, 2019
@NathanGibbs3
20190622 Issue #5 Work 2.1
46d48aa
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190623 Issue #5 Work 1
59d2e47
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 1
444dec5
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 2
bde9c20
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 3
1951576
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 4
69d3310
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
Revert "20190624 Issue #5 Work 4"
45ecc6f 
This reverts commit 69d3310.
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 4.1
8ede836
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 5
8a1f547
NathanGibbs3 added a commit that referenced this issue Jun 24, 2019
@NathanGibbs3
20190624 Issue #5 Work 6
6858491
NathanGibbs3 added a commit that referenced this issue Jun 25, 2019
@NathanGibbs3
20190624 Issue #5 Work 7
83329f8
NathanGibbs3 added a commit that referenced this issue Jun 25, 2019
@NathanGibbs3
20190624 Issue #5 Work 8
7660136
NathanGibbs3 added a commit that referenced this issue Jun 25, 2019
@NathanGibbs3
20190624 Issue #5 Work 9
4f0ed5f
@NathanGibbs3 NathanGibbs3 mentioned this issue Jun 25, 2019
Open
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 4, 2019
Closed
@NathanGibbs3 NathanGibbs3 added the New-TechDebt Issue caused by previous commit to this repo. We created it. label Sep 15, 2020
@NathanGibbs3 NathanGibbs3 mentioned this issue Sep 27, 2020
Closed
@NathanGibbs3 NathanGibbs3 mentioned this issue Aug 19, 2022
Closed
NathanGibbs3 added a commit that referenced this issue May 11, 2023
@NathanGibbs3
20230511 Fix CI build breakage. #5
79167b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
invalid This doesn't seem right New-TechDebt Issue caused by previous commit to this repo. We created it. Tests Test Code & Config Issues. Local or CI Environments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NathanGibbs3