Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultipleElementCriteria::PrintForm() PHP Notice: Uninitialized string/Undefined offset: 0 #10

Closed
NathanGibbs3 opened this issue Mar 10, 2019 · 2 comments
Closed

MultipleElementCriteria::PrintForm() PHP Notice: Uninitialized string/Undefined offset: 0 #10

NathanGibbs3 opened this issue Mar 10, 2019 · 2 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment.

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented Mar 10, 2019 •
edited
Loading

Item Description
File: includes/base_state_citems.inc.php
Class: MultipleElementCriteria
Function: PrintForm()
Related Issues: #5
Depends on Issue(s): #54
Dependency Type: Hard
Misc. Info.: These are instances where Issues #54 is not in play. Requesting the search function in the app causes this.

Expected Behavior: No error notices in logs.
Current Behavior: App is generating the above PHP Notices in logs.

Other Info: Related Files
base_qry_main.php
base_qry_form.php
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Prod Observed in Production Environment. labels Mar 10, 2019
NathanGibbs3 referenced this issue Mar 10, 2019
@NathanGibbs3
20190308 Issue #6 Partial Fix 1
ced2344 
File: includes/base_state_citems.inc.php

Changes to class BaseCriteria
Add NULL placeholder params to some function definitions.
For compatiblity with overrides that are already in the code.

Added placeholder params to overrides when necessary.
Added '' params to function calls when necessary.
PHPUnit has stopped throwing PHP Warnings. 😄

Testing in production, yields "PHP Warning:  Missing argument " errors.
From function calls located in other files.
Most likelly the base_qry_* files.
@NathanGibbs3
Copy link
Owner Author

NathanGibbs3 commented Mar 11, 2019 •
edited
Loading

Based on Review of some older production Logs this issue is present in the Legacy BASE code.

@NathanGibbs3 NathanGibbs3 added the LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. label Mar 11, 2019
@NathanGibbs3 NathanGibbs3 self-assigned this May 14, 2019
@NathanGibbs3 NathanGibbs3 reopened this May 14, 2019
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 5, 2019
Open
NathanGibbs3 added a commit that referenced this issue Jul 11, 2019
@NathanGibbs3
20190710 Issue #10 Work 1
0f88f81
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 1
b886bfc
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 2
1b23c40
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 3
a57199b
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 4
b9b40bf
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 5
b7915f0
NathanGibbs3 added a commit that referenced this issue Jul 12, 2019
@NathanGibbs3
20190712 Issue #10 Work 6
9b7b9be 
         Imported some Code fixes from Issue11 branch.
NathanGibbs3 added a commit that referenced this issue Jul 13, 2019
@NathanGibbs3
20190712 Issue #10 Work 7
bd0568d
NathanGibbs3 added a commit that referenced this issue Jul 13, 2019
@NathanGibbs3
20190712 Issue #10 Work 8
144f48d
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 13, 2019
Open
NathanGibbs3 added a commit that referenced this issue Jul 13, 2019
@NathanGibbs3
20190712 Issue #10 Work 9
ce5f760 
         Issue #54 Work 1
@NathanGibbs3
Copy link
Owner Author

I think we fixed this in commit 822697d
Haven't seen it in the logs since 1-25-2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NathanGibbs3