Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are failing on Node 0.10 #26

Closed
nathanhleung opened this issue May 30, 2018 · 5 comments
Closed

tests are failing on Node 0.10 #26

nathanhleung opened this issue May 30, 2018 · 5 comments
Labels
bug

Comments

@nathanhleung
Copy link
Owner

need to get tests working on 0.10
@nathanhleung nathanhleung changed the title test are failing on Node 0.10 tests are failing on Node 0.10 May 30, 2018
@nathanhleung
Copy link
Owner Author

Fixed by #28

@ljharb
Copy link
Collaborator

ljharb commented Jun 15, 2018

Not actually fixed; just allowed to fail.

The only solution is switching from jest to tape, since tape is the only remaining test runner that works on older nodes. (This should be reopened)

@nathanhleung nathanhleung reopened this Jun 15, 2018
@ljharb
Copy link
Collaborator

ljharb commented Jun 15, 2018

Happy to send a PR switching to tape if you’re willing to accept it!

@nathanhleung
Copy link
Owner Author

That would be wonderful! I was looking at some other test runners (Mocha etc) but all of them have stopped supporting Node <4. Is Tape used at Airbnb?

@ljharb
Copy link
Collaborator

ljharb commented Jun 15, 2018

We use it for some of our public packages, and will be likely migrating all of them (that support older nodes) to it.

@ljharb ljharb mentioned this issue Jun 15, 2018
Merged
nathanhleung pushed a commit that referenced this issue Jun 18, 2018
@ljharb @nathanhleung
[Tests] use tape instead of jest, to support older nodes.
688b6ea 
Fixes #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @nathanhleung