Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] inline has-yarn, to restore compat to older nodes #28

Merged
merged 2 commits into from
Jun 15, 2018
Merged

[Fix] inline has-yarn, to restore compat to older nodes #28

merged 2 commits into from
Jun 15, 2018

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Jun 15, 2018

Fixes #27

@nathanhleung
Copy link
Owner

Thanks for the pull request and thanks for fixing the tests!

@nathanhleung nathanhleung merged commit 292a9e4 into nathanhleung:master Jun 15, 2018
@ljharb ljharb deleted the has-yarn branch June 15, 2018 18:09
@nathanhleung
Copy link
Owner

ALso, could you explain what the matrix entry in .travis.yml does, exactly? I see it runs the scripts but I'm not exactly sure why some entries are in include and others are in the top-level config.

@ljharb
Copy link
Collaborator Author

ljharb commented Jun 15, 2018

The top-level config currently only has one env entry, so it runs that for each of the node versions. The "include" is for one-offs - ie, include 1 lint run, and run "TEST" for all the nodes.

You might add additional one-offs, or additional variants that you want to run in "all nodes"

@ljharb
Copy link
Collaborator Author

ljharb commented Jun 15, 2018

(and thanks! looking forward to this being released)

@nathanhleung
Copy link
Owner

Been having problems publishing on my Windows box lately but will try and release ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants