fix crash with iOS 10 #34
Conversation
This patch should fix https://hipbyte.myjetbrains.com/youtrack/issue/RM-1097 If it would access to same URL with redirection, looks like Cocoa API break the stack or buffer, heap in internal of object which will be used to request since iOS 10. Then when objective-c runtime API would be called with broken object, it will cause a crash. This patch will get rid of redirection to same URL.
|
@Watson1978 seeing that you're from HipByte, any idea why the CI is failing? =D Also happy to give you commit access to this repo if you're interested ~ |
|
I looked a Travis CI log. I did not try with old Xcode 6. The Travis CI log indicates |
|
You can change the Xcode version in Travis with |
|
If you give me commit access, I will be happy :) |
|
@Watson1978 granted! I'll add you as a rubygem owner as well, what email should I add? |
|
@nathankot Could you add watson1978@gmail.com ? :) Thank you. |
|
@Watson1978 added! feel free to push a new version with the change, thanks =D |
|
@nathankot Thank you!! I will try it :) |
|
@nathankot I was to able to push new version to RubyGems.org :) Thank you ! |
|
@Watson1978 awesome, thanks! |
This patch should fix https://hipbyte.myjetbrains.com/youtrack/issue/RM-1097
If it would access to same URL with redirection, looks like Cocoa API break the stack or buffer, heap in internal of object which will be used to request since iOS 10.
Then when objective-c runtime API would be called with broken object, it will cause a crash.
This patch will get rid of redirection to same URL.