Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'lein uberjar' doesn't include compiled classes for dfs-datastore #51

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bhiles
Copy link

@bhiles bhiles commented Jun 30, 2015

Here is some code to reproduce the issue

$ cd dfs-datastores/dfs-datastores/

$ lein uberjar
Compiling 53 source files to /Users/bhiles/src/dfs-datastores/dfs-datastores/target/classes
warning: [options] bootstrap class path not set in conjunction with -source 1.6
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning
Created target/dfs-datastores-1.3.7-SNAPSHOT.jar
Created target/javadoc/dfs-datastores-1.3.7-SNAPSHOT-javadoc.jar
Created target/sources/dfs-datastores-1.3.7-SNAPSHOT-sources.jar
Created target/dfs-datastores-1.3.7-SNAPSHOT-standalone.jar

# No .class file for backtype is found :(
$ jar -tf target/dfs-datastores-1.3.7-SNAPSHOT-standalone.jar | grep back | grep .class
com/google/common/util/concurrent/FutureCallback.class

# After adding the change for this PR
› lein uberjar
Compiling 53 source files to /Users/bhiles/src/dfs-datastores/dfs-datastores/target/classes
warning: [options] bootstrap class path not set in conjunction with -source 1.6
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning
Created /Users/bhiles/src/dfs-datastores/dfs-datastores/target/dfs-datastores-1.3.7-SNAPSHOT.jar
Created /Users/bhiles/src/dfs-datastores/dfs-datastores/target/dfs-datastores-1.3.7-SNAPSHOT-standalone.jar

# Here you can find many backtype compiled classes
$ jar -tf target/dfs-datastores-1.3.7-SNAPSHOT-standalone.jar | grep back | grep .class | head
com/backtype/hadoop/AbstractFileCopyMapper.class
com/backtype/hadoop/BalancedDistcp$1.class
com/backtype/hadoop/BalancedDistcp$BalancedDistcpMapper.class
com/backtype/hadoop/BalancedDistcp.class
com/backtype/hadoop/Coercer$1.class
com/backtype/hadoop/Coercer$CoercerMapper.class
com/backtype/hadoop/Coercer.class
com/backtype/hadoop/Consolidator$1.class
com/backtype/hadoop/Consolidator$ConsolidatorArgs.class
com/backtype/hadoop/Consolidator$ConsolidatorInputFormat$1.class

I'm not quite sure how the :classifier logic works, I see it's included in this commit. To try and validate nothing is broken on the pom side, I ran lein pom before and after the change, and came up with the same file.

Lastly, I've only modified the dfs-datastores/dfs-datastores/project.clj, so I'll need to modify the dfs-datastores/dfs-datastores-cascading/project.clj if this a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant