GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
NOTE: The current version of storm-deploy is currently BROKEN by the bugs for which fixes this pull request contains.
To be clear, the current version of storm-deploy must not have been tested because the following two issues are currently on the master branch and should affect ANY environment:
The pallet code that executes the call to the build_release.sh script utilizes the (sh) function which obviously will not work because BASH is required to execute Storm's build_release script.
The (get-release) function does not properly build the BASH conditional which checks for the release version specified on the CLI and simply ignores it even if it is present, resulting in an automatic install attempt of whatever is on the master branch of the Storm repo. This is obviously bad news since the bleeding edge is usually not desired in production.
I have included fixes for both of these issues and thoroughly tested them from a completely scratch deployment. I urge this request to be merged in as quickly as possible since I cannot see the current version working under any circumstances.
fixed bash execution environment for storm build and fixed pallet par…
…sing for release parameter
We are working on implementing vmfest, which will make it much easier to debug the system. In the meantime, I thank you for your pull request. I will take a look at it tonight.
@jasonjckn Sorry-- implemented in hurry since I was concerned about breakage. I will refactor using binds and push the change in a few minutes.
@KasperMadsen vmfest sounds great, I'll keep that in mind when making future contributions. Would also love to see a separate branch with the beginnings of that so I can help out.
refactored get-release to use bound symbols instead of some hackish d…
All set, let me know if you need anything else before merge.
Merge pull request #20 from petermelias/master
Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script