Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script #20

Merged
merged 2 commits into from Jan 30, 2013

Conversation

Projects
None yet
3 participants
Contributor

petermelias commented Jan 30, 2013

NOTE: The current version of storm-deploy is currently BROKEN by the bugs for which fixes this pull request contains.

To be clear, the current version of storm-deploy must not have been tested because the following two issues are currently on the master branch and should affect ANY environment:

  1. The pallet code that executes the call to the build_release.sh script utilizes the (sh) function which obviously will not work because BASH is required to execute Storm's build_release script.

  2. The (get-release) function does not properly build the BASH conditional which checks for the release version specified on the CLI and simply ignores it even if it is present, resulting in an automatic install attempt of whatever is on the master branch of the Storm repo. This is obviously bad news since the bleeding edge is usually not desired in production.

I have included fixes for both of these issues and thoroughly tested them from a completely scratch deployment. I urge this request to be merged in as quickly as possible since I cannot see the current version working under any circumstances.

Collaborator

KasperMadsen commented Jan 30, 2013

Hi Peter
We are working on implementing vmfest, which will make it much easier to debug the system. In the meantime, I thank you for your pull request. I will take a look at it tonight.

Contributor

petermelias commented Jan 30, 2013

@jasonjckn Sorry-- implemented in hurry since I was concerned about breakage. I will refactor using binds and push the change in a few minutes.

@KasperMadsen vmfest sounds great, I'll keep that in mind when making future contributions. Would also love to see a separate branch with the beginnings of that so I can help out.

Contributor

petermelias commented Jan 30, 2013

All set, let me know if you need anything else before merge.

@jasonjckn jasonjckn added a commit that referenced this pull request Jan 30, 2013

@jasonjckn jasonjckn Merge pull request #20 from petermelias/master
Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script
868894f

@jasonjckn jasonjckn merged commit 868894f into nathanmarz:master Jan 30, 2013

Collaborator

jasonjckn commented Jan 30, 2013

thanks again.

Contributor

petermelias commented Jan 30, 2013

anytime 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment