Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing for release parameter
|
Hi Peter |
|
@jasonjckn Sorry-- implemented in hurry since I was concerned about breakage. I will refactor using binds and push the change in a few minutes. @KasperMadsen vmfest sounds great, I'll keep that in mind when making future contributions. Would also love to see a separate branch with the beginnings of that so I can help out. |
|
All set, let me know if you need anything else before merge. |
jasonjckn
added a commit
that referenced
this pull request
Jan 30, 2013
Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script
|
thanks again. |
|
anytime 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The current version of storm-deploy is currently BROKEN by the bugs for which fixes this pull request contains.
To be clear, the current version of storm-deploy must not have been tested because the following two issues are currently on the master branch and should affect ANY environment:
The pallet code that executes the call to the build_release.sh script utilizes the (sh) function which obviously will not work because BASH is required to execute Storm's build_release script.
The (get-release) function does not properly build the BASH conditional which checks for the release version specified on the CLI and simply ignores it even if it is present, resulting in an automatic install attempt of whatever is on the master branch of the Storm repo. This is obviously bad news since the bleeding edge is usually not desired in production.
I have included fixes for both of these issues and thoroughly tested them from a completely scratch deployment. I urge this request to be merged in as quickly as possible since I cannot see the current version working under any circumstances.