Skip to content

Commit

Permalink
Merge pull request #532 from jasonjckn/0.9.0-ibackingmap
Browse files Browse the repository at this point in the history
MicroBatchIBackingMap: avoid store timeouts on multiput and multiget
  • Loading branch information
nathanmarz committed Apr 2, 2013
2 parents 4cdfc45 + 69f1d2a commit 78b9f99
Showing 1 changed file with 68 additions and 0 deletions.
68 changes: 68 additions & 0 deletions src/jvm/storm/trident/state/map/MicroBatchIBackingMap.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
package storm.trident.state.map;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;

public class MicroBatchIBackingMap<T> implements IBackingMap<T> {
IBackingMap<T> _delegate;
Options _options;


public static class Options implements Serializable {
public int maxMultiGetBatchSize = 0; // 0 means delegate batch size = trident batch size.
public int maxMultiPutBatchSize = 0;
}

public MicroBatchIBackingMap(final Options options, final IBackingMap<T> delegate) {
_options = options;
_delegate = delegate;
assert options.maxMultiPutBatchSize >= 0;
assert options.maxMultiGetBatchSize >= 0;
}

@Override
public void multiPut(final List<List<Object>> keys, final List<T> values) {
int thisBatchSize;
if(_options.maxMultiPutBatchSize == 0) { thisBatchSize = keys.size(); }
else { thisBatchSize = _options.maxMultiPutBatchSize; }

LinkedList<List<Object>> keysTodo = new LinkedList<List<Object>>(keys);
LinkedList<T> valuesTodo = new LinkedList<T>(values);

while(!keysTodo.isEmpty()) {
List<List<Object>> keysBatch = new ArrayList<List<Object>>(thisBatchSize);
List<T> valuesBatch = new ArrayList<T>(thisBatchSize);
for(int i=0; i<thisBatchSize && !keysTodo.isEmpty(); i++) {
keysBatch.add(keysTodo.removeFirst());
valuesBatch.add(valuesTodo.removeFirst());
}

_delegate.multiPut(keysBatch, valuesBatch);
}
}

@Override
public List<T> multiGet(final List<List<Object>> keys) {
int thisBatchSize;
if(_options.maxMultiGetBatchSize == 0) { thisBatchSize = keys.size(); }
else { thisBatchSize = _options.maxMultiGetBatchSize; }

LinkedList<List<Object>> keysTodo = new LinkedList<List<Object>>(keys);

List<T> ret = new ArrayList<T>(keys.size());

while(!keysTodo.isEmpty()) {
List<List<Object>> keysBatch = new ArrayList<List<Object>>(thisBatchSize);
for(int i=0; i<thisBatchSize && !keysTodo.isEmpty(); i++) {
keysBatch.add(keysTodo.removeFirst());
}

List<T> retSubset = _delegate.multiGet(keysBatch);
ret.addAll(retSubset);
}

return ret;
}
}

0 comments on commit 78b9f99

Please sign in to comment.