Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ShellBolts to optionally specify the logging level. #626

Closed
wants to merge 3 commits into from

Conversation

msukmanowsky
Copy link

Default logging will still be info to support backwards compatibility.

@nathanmarz
Copy link
Owner

Can you send me a contributor agreement? Instructions here: https://github.com/nathanmarz/storm/wiki/Contributing-to-Storm

@msukmanowsky
Copy link
Author

Sent!

@nathanmarz
Copy link
Owner

I'm not a fan of this implementation. Can you use numbers instead of strings for specifying the level? 0 = debug, 1 = info, etc. And it seems like it should test against info first because that's the common case.

@msukmanowsky
Copy link
Author

Hmm, considering this is implemented in the ShellBolt, having an enum kind of implementation (0 = debug, 1 = info) means that each language would need to maintain the same kind of enum. I thought it'd be an easier interface for the languages to specify the log level using a string no?

@nathanmarz
Copy link
Owner

Numbers are more performant. This is a protocol, it should be done efficiently.

@msukmanowsky
Copy link
Author

Alright, think we're all set here, mind giving it a look @nathanmarz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants