Configurable temporary file location #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, Nathan I'm just doing one more thing now and that's around updating package versions to the current latest required. Additionally, I think I can move |
|
Hey Damon, Nice thinking about the configurable location - I've merged all the changes in and bumped the version to 0.1.0. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Nathan,
Just made a tweak to the multipart uploader so it let's you configure the temporary folder location (falls back to
os.tmpDir()if none specified).Additionally, just a few syntax tweaks that jshint was nagging me about.
Also, I reckon this module deserves at least a 0.1.x status :)
Have a good weekend!
Cheers,
Damon.