Added noDisk option that keeps each part's content in memory instead of in a temp file #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform as a service offerings such as nodejitsu either forbid or limit disk writes. With the current implementation I was unable to large amounts of text (giant generated CSV files) to S3 as the application would throw errors.
I've added a
noDisk
option which when set to true keeps the data for each part in-memory instead of writing to a temporary file. It defaults to false.Also added trivial change of including status code when an error is thrown because response code is not 200, as this was helpful for debugging.