Fix to ensure that constructor returned prototypes are not lost

nathanoehlman · Mar 17, 2012 · 8a1023b · 8a1023b
1 parent 6784c62
commit 8a1023b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/registry.common.js b/registry.common.js
@@ -105,6 +105,14 @@ var wildcard = require('wildcard'),
                 // if the new object has successfully been created, and is of type object
                 // then assign the prototype
                 if (typeof newObject == 'object') {
+                    // copy any methods from the object prototype into this prototype
+                    if (newObject.__proto__ !== this._prototype) {
+                        for (var key in newObject.__proto__) {
+                            this._prototype[key] = newObject.__proto__[key];
+                        }
+                    }
+
+                    // retarget the new object prototype
                     newObject.__proto__ = this._prototype;
                 }
 

diff --git a/registry.js b/registry.js
@@ -102,6 +102,14 @@
                 // if the new object has successfully been created, and is of type object
                 // then assign the prototype
                 if (typeof newObject == 'object') {
+                    // copy any methods from the object prototype into this prototype
+                    if (newObject.__proto__ !== this._prototype) {
+                        for (var key in newObject.__proto__) {
+                            this._prototype[key] = newObject.__proto__[key];
+                        }
+                    }
+
+                    // retarget the new object prototype
                     newObject.__proto__ = this._prototype;
                 }
 

diff --git a/src/core/definition.js b/src/core/definition.js
@@ -39,6 +39,14 @@ RegistryDefinition.prototype = {
             // if the new object has successfully been created, and is of type object
             // then assign the prototype
             if (typeof newObject == 'object') {
+                // copy any methods from the object prototype into this prototype
+                if (newObject.__proto__ !== this._prototype) {
+                    for (var key in newObject.__proto__) {
+                        this._prototype[key] = newObject.__proto__[key];
+                    }
+                }
+
+                // retarget the new object prototype
                 newObject.__proto__ = this._prototype;
             }