Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: type error fix #280

Closed
wants to merge 3 commits into from
Closed

Conversation

abhisheknaiidu
Copy link
Member

@abhisheknaiidu abhisheknaiidu commented May 30, 2024

fixes #279

@abhisheknaiidu abhisheknaiidu requested a review from a team as a code owner May 30, 2024 19:49
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
citizen-app-mainnet ✅ Ready (Inspect) Visit Preview Jun 1, 2024 6:36am
citizen-app-sepolia ✅ Ready (Inspect) Visit Preview Jun 1, 2024 6:36am

Copy link

vercel bot commented May 30, 2024

@abhisheknaiidu is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.79%. Comparing base (9938b54) to head (d676643).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   11.79%   11.79%           
=======================================
  Files          18       18           
  Lines         356      356           
  Branches       80       80           
=======================================
  Hits           42       42           
  Misses        308      308           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhisheknaiidu
Copy link
Member Author

@aahna-ashina now check once, i've updated it.

Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhisheknaiidu Nothing happens when I click the button at https://citizen-app-mainnet-1hmu5t0dy-nation3dao.vercel.app/lock:

But there is an error in the Console:

Uncaught (in promise) TypeError: y is not a function
    at 393-8620b5378a428cb4.js:1:2922
    at s (main-1d8adce4d7e8417e.js:1:89184)
    at Generator._invoke (main-1d8adce4d7e8417e.js:1:88972)
    at P.forEach.e.<computed> [as next] (main-1d8adce4d7e8417e.js:1:89607)
    at f (393-8620b5378a428cb4.js:1:2022)
    at s (393-8620b5378a428cb4.js:1:3189)
    at 393-8620b5378a428cb4.js:1:3248
    at new Promise (<anonymous>)
    at 393-8620b5378a428cb4.js:1:3129
    at 393-8620b5378a428cb4.js:1:3290

@aahna-ashina
Copy link
Member

Fixed in #281

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when withdrawing previous lock
2 participants